Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the new MinDomainsInPodTopologySpread feature gate #32340

Merged
merged 1 commit into from Apr 12, 2022
Merged

Document the new MinDomainsInPodTopologySpread feature gate #32340

merged 1 commit into from Apr 12, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 18, 2022

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2022
@netlify
Copy link

netlify bot commented Mar 18, 2022 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit e4a473c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/624ff4de1e2a9300092ac64b

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 18, 2022
@mehabhalodiya
Copy link
Contributor

enhancement ref: kubernetes/enhancements/issues/3022

@mehabhalodiya mehabhalodiya mentioned this pull request Mar 19, 2022
Closed
12 tasks
@mehabhalodiya
Copy link
Contributor

/assign @PI-Victor

sanposhiho
sanposhiho reviewed Mar 19, 2022
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR instead of me 👍

content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md
- **whenUnsatisfiable** indicates how to deal with a Pod if it doesn't satisfy the spread constraint:
- `DoNotSchedule` (default) tells the scheduler not to schedule it.
- `ScheduleAnyway` tells the scheduler to still schedule it while prioritizing nodes that minimize the skew.

- **labelSelector** is used to find matching Pods. Pods that match this label selector are counted to determine the number of Pods in their corresponding topology domain. See [Label Selectors](/docs/concepts/overview/working-with-objects/labels/#label-selectors) for more details.

When a Pod defines more than one `topologySpreadConstraint`, those constraints are ANDed: The kube-scheduler looks for a node for the incoming Pod that satisfies all the constraints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the example to describe minDomains?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer adding the example as a mermaid diagram in a separate PR.

content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md Show resolved Hide resolved
content/en/docs/concepts/workloads/pods/pod-topology-spread-constraints.md Outdated Show resolved Hide resolved
@tengqm tengqm force-pushed the mindomainsintopologyspread branch from 7cd5d4d to e64cce3 Compare March 20, 2022 00:44
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2022
@reylejano
Copy link
Member

Code PR merged in kubernetes/kubernetes#107674
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7eeccfc070341850400e274b10535b7f615b23e3

@mehabhalodiya
Copy link
Contributor

/cc @nate-double-u

@mehabhalodiya
Copy link
Contributor

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Mar 25, 2022
@PI-Victor
Copy link
Member

/lgtm
anything stopping us from merging this? the code has been merged and the PR seems good to go
cc @nate-double-u

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2022
@tengqm tengqm force-pushed the mindomainsintopologyspread branch from e64cce3 to 806994a Compare April 1, 2022 23:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 1, 2022
@tengqm tengqm force-pushed the mindomainsintopologyspread branch from 806994a to e4a473c Compare April 8, 2022 08:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2022
@nate-double-u
Copy link
Contributor

@PI-Victor, the LGTM got dropped after the last commit. Re-add and I'd be happy to approve.

chrisnegus
chrisnegus reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5d1f25ab44b4143ca0a19a1c037d4b76d319c9d

@nate-double-u
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nate-double-u

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2022
@k8s-ci-robot k8s-ci-robot merged commit 007d252 into kubernetes:dev-1.24 Apr 12, 2022
@tengqm tengqm deleted the mindomainsintopologyspread branch April 12, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisnegus chrisnegus chrisnegus left review comments

@sanposhiho sanposhiho sanposhiho left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@onlydole onlydole Awaiting requested review from onlydole

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@PI-Victor PI-Victor Awaiting requested review from PI-Victor

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@PI-Victor PI-Victor

@chrisnegus chrisnegus

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tengqm @mehabhalodiya @reylejano @k8s-ci-robot @PI-Victor @nate-double-u @chrisnegus @sanposhiho