Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving windows containers user guide out of /setup/production-environment/ #32691

Closed
wants to merge 1 commit into from
Closed

Moving windows containers user guide out of /setup/production-environment/ #32691

wants to merge 1 commit into from

Conversation

marosset
Copy link
Contributor

Signed-off-by: Mark Rossetti marosset@microsoft.com

Part of #31428

/hold
We want to merge changes related to #31428 at the same time.

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 31, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2022
@netlify
Copy link

netlify bot commented Mar 31, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 574d541
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/624c9add92a52800080ce8b1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 31, 2022
@marosset
Copy link
Contributor Author

/sig windows
/label refactor

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign natalisucks after the PR has been reviewed.
You can assign the PR to them by writing /assign @natalisucks in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 31, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 31, 2022
@marosset marosset force-pushed the move-windows-user-guide-1.24 branch from 622afa1 to 5c8aefa Compare March 31, 2022 19:27
@marosset marosset mentioned this pull request Mar 31, 2022
Open
31 tasks
@RA489
Copy link

RA489 commented Apr 1, 2022

@marosset Please rebase your PR.

@marosset
Copy link
Contributor Author

marosset commented Apr 5, 2022

/hold
We want all the PRs that break up /modify https://kubernetes.io/docs/setup/production-environment/windows/intro-windows-in-kubernetes/
See #31851 (comment)

@marosset
Moving windows containers user guide out of /setup/production-environ…
574d541 
…ment/

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@marosset marosset force-pushed the move-windows-user-guide-1.24 branch from 5c8aefa to 574d541 Compare April 5, 2022 19:39
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2022
@nate-double-u
Copy link
Contributor

Hi @marosset, I don't think this PR should target dev-1.24

@marosset
Copy link
Contributor Author

/close
I will squash the commits and create a single PR with all of the related changes targeting main.

@k8s-ci-robot
Copy link
Contributor

@marosset: Closed this PR.

In response to this:

/close
I will squash the commits and create a single PR with all of the related changes targeting main.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nate-double-u
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.24 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalisucks natalisucks Awaiting requested review from natalisucks

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language refactor Indicates a PR with large refactoring changes e.g. removes files or moves content sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marosset @k8s-ci-robot @RA489 @nate-double-u