-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for mixed protocol Services of type: LoadBalancer #32696
Conversation
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
content/en/docs/reference/command-line-tools-reference/feature-gates.md
Outdated
Show resolved
Hide resolved
/retitle Update docs for mixed protocol Services of type: LoadBalancer |
…-gates.md Co-authored-by: Qiming Teng <tengqm@outlook.com>
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs PRs are due today (IIRC)
Remember to include any required updates to https://kubernetes.io/docs/concepts/services-networking/service/#load-balancers-with-mixed-protocol-types
/assign |
Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown LGTM
@kubernetes/sig-network-pr-reviews is this change technically correct? Anything overlooked? Please add /lgtm if it's all good.
/lgtm |
LGTM label has been added. Git tree hash: 4b0a0fad098360d64b69a5ed30458db5effad8eb
|
This is a pull request for docs updates as we move MixedProtocolLBService from alpha to beta.
k/k PR: kubernetes/kubernetes#109213
enhancements issue: kubernetes/enhancements#1435
Signed-off-by: Bridget Kromhout bridget@kromhout.org