Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for mixed protocol Services of type: LoadBalancer #32696

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

bridgetkromhout
Copy link
Member

@bridgetkromhout bridgetkromhout commented Apr 1, 2022

This is a pull request for docs updates as we move MixedProtocolLBService from alpha to beta.

k/k PR: kubernetes/kubernetes#109213
enhancements issue: kubernetes/enhancements#1435

Signed-off-by: Bridget Kromhout bridget@kromhout.org

Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Apr 1, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 1, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 1, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 1, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 1, 2022 00:02
@netlify
Copy link

netlify bot commented Apr 1, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 6571bea
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/624c94928f67730008c78fe5

@sftim
Copy link
Contributor

sftim commented Apr 1, 2022

/retitle Update docs for mixed protocol Services of type: LoadBalancer

@k8s-ci-robot k8s-ci-robot changed the title Feature flag change when moving from alpha to beta Update docs for mixed protocol Services of type: LoadBalancer Apr 1, 2022
…-gates.md

Co-authored-by: Qiming Teng <tengqm@outlook.com>
@tengqm
Copy link
Contributor

tengqm commented Apr 1, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 1, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs PRs are due today (IIRC)

Remember to include any required updates to https://kubernetes.io/docs/concepts/services-networking/service/#load-balancers-with-mixed-protocol-types

@nate-double-u
Copy link
Contributor

/assign

Signed-off-by: Bridget Kromhout <bridget@kromhout.org>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2022
@bridgetkromhout bridgetkromhout marked this pull request as ready for review April 5, 2022 19:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2022
@tengqm
Copy link
Contributor

tengqm commented Apr 6, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown LGTM

@kubernetes/sig-network-pr-reviews is this change technically correct? Anything overlooked? Please add /lgtm if it's all good.

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Apr 6, 2022
@tengqm
Copy link
Contributor

tengqm commented Apr 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4b0a0fad098360d64b69a5ed30458db5effad8eb

@k8s-ci-robot k8s-ci-robot merged commit a8b4607 into kubernetes:dev-1.24 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants