Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[en] Clean up various broken links #32913

Merged
merged 2 commits into from
Jun 16, 2022
Merged

[en] Clean up various broken links #32913

merged 2 commits into from
Jun 16, 2022

Conversation

tallclair
Copy link
Member

Clean up broken links reported through the HackerOne bug bounty program.

Localized version of #32783

/committee security-response

@k8s-ci-robot k8s-ci-robot added committee/security-response Denotes an issue or PR intended to be handled by the product security committee. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added language/de Issues or PRs related to German language language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 13, 2022
@netlify
Copy link

netlify bot commented Apr 14, 2022

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 01b2a80
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62576294bdedc90008b4d773
😎 Deploy Preview https://deploy-preview-32913--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 14, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit ce45734
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62683e48875d2b0009f7f687
😎 Deploy Preview https://deploy-preview-32913--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jihoon-seo
Copy link
Member

/remove-language de

@k8s-ci-robot k8s-ci-robot removed the language/de Issues or PRs related to German language label Apr 14, 2022
sftim
sftim reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIG Docs policy is not to revise blog posts more than 1 year old. We add a banner advising readers to check pages haven't gone out of date.

http://romana.io/ is not malware, it's just a broken link.

I want to record that accepting this change does not set a precedent for other PRs that propose to revise old articles.

How do these suggestions look?

content/en/blog/_posts/2016-04-00-Kubernetes-Network-Policy-APIs.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2016-09-00-High-Performance-Network-Policies-Kubernetes.md Outdated Show resolved Hide resolved
@tallclair
Copy link
Member Author

http://romana.io/ is not malware, it's just a broken link.

The security risk is that someone could purchase that domain, make a look-alike page to the real romana destination, and provide malware downloads. I agree it's low priority, but that's why we're treating this as a security vulnerability. Note that this only applies to nxdomains (or unregistered domains), not to broken paths that 404.

@sftim
Copy link
Contributor

sftim commented Apr 25, 2022

Usual SIG Docs blog policy is not to revise blog posts more than 1 year old; we can make an exception of course.

How do you feel about removing the links to Romana as I've suggested @tallclair ?

@tallclair
Copy link
Member Author

Yeah, I'm fine with removing the links.

nate-double-u
nate-double-u reviewed Jun 15, 2022
View reviewed changes
content/en/blog/_posts/2017-08-00-High-Performance-Networking-With-Ec2.md
@@ -73,8 +73,5 @@ When using Romana v2.0, native VPC networking is now available for clusters of a
![](https://archive.org/download/hpc-ec2-vpc-2/hpc-ec2-vpc-2.png)


The preview release of Romana v2.0 is available [here](http://romana.io/preview). We welcome comments and feedback so we can make EC2 deployments of Kubernetes as fast and reliable as possible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to remove this whole paragraph. Could we do something like this instead:

Suggested change
The preview release of Romana v2.0 is available [here](http://romana.io/preview). We welcome comments and feedback so we can make EC2 deployments of Kubernetes as fast and reliable as possible.
The preview release of Romana v2.0 is available here _Editor's Note:_ link removed. We welcome comments and feedback so we can make EC2 deployments of Kubernetes as fast and reliable as possible.

@sftim do we have any history of providing Editor's Notes? is this the format they'd be?

Copy link
Contributor

@zacharysarah zacharysarah Jun 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nate-double-u We've used editor's notes at the top of other blog posts. I'd prefer a different format, but I'd rather expedite the security concern so we can discuss formatting in a non-blocking way.

@zacharysarah
Copy link
Contributor

@tallclair Thanks for your patience.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5f8e05cb0c09d3b85499b02842ccfd48c0d6f467

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3504060 into kubernetes:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah left review comments

@nate-double-u nate-double-u nate-double-u left review comments

@sftim sftim sftim left review comments

@bene2k1 bene2k1 Awaiting requested review from bene2k1

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@zacharysarah zacharysarah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/security-response Denotes an issue or PR intended to be handled by the product security committee. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tallclair @jihoon-seo @sftim @zacharysarah @k8s-ci-robot @nate-double-u