Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up various broken links #32783

Closed
wants to merge 3 commits into from
Closed

Clean up various broken links #32783

wants to merge 3 commits into from

Conversation

tallclair
Copy link
Member

Multus-cni

Contiv.io

Romana

  • Newly reported

See #32778 for a discussion of a general solution.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tengqm after the PR has been reviewed.
You can assign the PR to them by writing /assign @tengqm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/de Issues or PRs related to German language labels Apr 6, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 6, 2022
@netlify
Copy link

netlify bot commented Apr 6, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-io-main-staging ready!

Name Link
🔨 Latest commit 3393f8e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/624f15fc50192300098db441
😎 Deploy Preview https://deploy-preview-32783--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nasa9084
Copy link
Member

nasa9084 commented Apr 7, 2022

LGTM from japanese perspective, but can you create PRs per language?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2022
@tallclair
Copy link
Member Author

@nasa9084 is that really necessary? This is just global find/replace of URLs (not something translated) and braking this into 9 separate PRs will be annoying...

@bradtopol
Copy link
Contributor

/assign
Hi @tallclair thanks you for your contribution. Please break this up into multiple PRs. There should be one PR per localization. Also, the blog updates should be in a separate PR as well. Thanks

@k8s-ci-robot
Copy link
Contributor

@tallclair: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2022
@tallclair tallclair mentioned this pull request Apr 13, 2022
Merged
This was referenced Apr 13, 2022
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
@tallclair
Copy link
Member Author

OK, I submitted separate PRs for each localization.

@tallclair tallclair closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@daminisatya daminisatya Awaiting requested review from daminisatya

Assignees

@bradtopol bradtopol

Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/zh Issues or PRs related to Chinese language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tallclair @k8s-ci-robot @nasa9084 @bradtopol