Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh]sync-setup-3 #33981

Merged
merged 1 commit into from
May 30, 2022
Merged

[zh]sync-setup-3 #33981

merged 1 commit into from
May 30, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented May 27, 2022

This one supersedes #33625.
Co-Authored-By: @wlp1153468871
related: #33475

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 27, 2022
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label May 27, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 27, 2022
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nitpicks.

@netlify
Copy link

netlify bot commented May 27, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit b11575a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6293714a6a3a2b00094ec0b9
😎 Deploy Preview https://deploy-preview-33981--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tengqm tengqm force-pushed the continue-33625 branch 3 times, most recently from 33c8b40 to 430349e Compare May 28, 2022 04:31
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

I think other fixes can leave it to next contributor. 😄


当某个 Linux 系统发行版使用 [systemd](https://www.freedesktop.org/wiki/Software/systemd/)
作为其初始化系统时,初始化进程会生成并使用一个 root 控制组 (`cgroup`), 并充当 cgroup 管理器。
作为其初始化系统时,初始化进程会生成并使用一个 root 控制组`cgroup`, 并充当 cgroup 管理器。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
作为其初始化系统时,初始化进程会生成并使用一个 root 控制组(`cgroup`, 并充当 cgroup 管理器。
作为其初始化系统时,初始化进程会生成并使用一个 root 控制组(`cgroup`并充当 cgroup 管理器。

@mengjiao-liu
Copy link
Member

/approve
/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d49497d56b43505de73888561af10d1c4d9a30ea

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9f8820b into kubernetes:main May 30, 2022
@tengqm tengqm deleted the continue-33625 branch May 30, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants