Improving copy to clipboard feature- Removing extra lines #34736

ayushtamra · 2022-06-30T15:27:28Z

Hello, this solves the issue of addition of extra lines, on "copy to clipboard". Implemented by making changes in the JavaScript, using JavaScript replace and trim function.

Deploy preview example yaml files which are now without extra lines:

Signed-off-by: ayushtamra <tamraayush@gmail.com>

linux-foundation-easycla · 2022-06-30T15:27:37Z

The committers listed above are authorized under a signed CLA.

✅ login: ayushtamra / name: Ayush Tamra (3d5f75e)

k8s-ci-robot · 2022-06-30T15:27:47Z

Welcome @ayushtamra!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-06-30T15:28:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign celestehorgan after the PR has been reviewed.
You can assign the PR to them by writing /assign @celestehorgan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2022-06-30T15:40:24Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`3d5f75e`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62bdc0e578fc6d0008a544f4
😎 Deploy Preview	https://deploy-preview-34736--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim · 2022-06-30T18:52:24Z

layouts/partials/hooks/body-end.html

@@ -23,6 +23,7 @@
      document.body.appendChild(target);
    }
    target.value = document.getElementById(elem).innerText;
+    target.value = target.value.replace(/\n\n/gm,"\n").trim();


Thanks @ayushtamra

I think this may be the wrong fix. If the original bug / behavior changes within Hugo then what gets copied could be different from what you get when you download the example.

At a minimum, this needs a clear comment that explains why the replace() happens.

Thanks for the feedback @sftim I would like to mention that maybe its related to the execCommand() which is doing the copy here.
Also I have seen an question posted on StackOverflow(don't know if it makes sense): https://stackoverflow.com/questions/34477425/javascript-execcommandcopy-copies-text-but-adds-extra-white-space-to-value
But I am sure to look into and learn if there is any issues related with hugo

Sea-n · 2022-08-29T06:04:39Z

Hey @ayushtamra,

Any updates on this PR? Seems the fix is stuck here.

ayushtamra · 2022-08-29T06:21:56Z

Hello @Sea-n I am actually able to solve this particular issue, by fixing the extra lines on a frontend level(a probable quick fix), but as mentioned I am not able to fix it at the root level, and will need help to solve it

tengqm · 2022-08-29T06:44:51Z

I gave this a quick research.

Based on the HTML source code we get from the browser, my understanding is that something is wrong with Hugo when parsing a YAML file. The extra empty lines are added by the builtin shortcodes invoked here. We need to investigate why the contents of different files under the same directory are processed differently.

k8s-triage-robot · 2022-11-27T07:41:04Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-12-27T08:28:27Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

divya-mohan0209 · 2022-12-28T03:05:29Z

/remove-lifecycle rotten

divya-mohan0209 · 2023-01-15T08:42:52Z

Hello @ayushtamra , are you interested in continuing to work on this PR and investigate per suggestion by @tengqm ? Please confirm in either case since if you aren't, we can open this up to contributors who'd be able to pick this up from here.

divya-mohan0209 · 2023-04-04T06:18:20Z

Hey @ayushtamra , since there has been no response to the feedback provided I will be closing the PR. If you wish to continue work, please consider reopening it by issuing a /reopen command.

/close

k8s-ci-robot · 2023-04-04T06:18:26Z

@divya-mohan0209: Closed this PR.

In response to this:

Hey @ayushtamra , since there has been no response to the feedback provided I will be closing the PR. If you wish to continue work, please consider reopening it by issuing a /reopen command.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Improving copy to clipboard feature- Removing extra lines

3d5f75e

Signed-off-by: ayushtamra <tamraayush@gmail.com>

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 30, 2022

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2022

k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 30, 2022

k8s-ci-robot requested review from divya-mohan0209 and kbhawkey June 30, 2022 15:28

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 30, 2022

sftim reviewed Jun 30, 2022

View reviewed changes

jihoon-seo mentioned this pull request Aug 16, 2022

Unwanted spaces in YAML file #36003

Closed

jihoon-seo mentioned this pull request Aug 29, 2022

debug-cluster/monitor-node-health: YAML file contains many empty lines #36361

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 27, 2022

jihoon-seo mentioned this pull request Nov 30, 2022

Blank lines when copying example manifests #37206

Closed

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 27, 2022

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 28, 2022

cjc7373 mentioned this pull request Mar 22, 2023

fix: eliminate extra lines when copying to clipboard #40226

Merged

k8s-ci-robot closed this Apr 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improving copy to clipboard feature- Removing extra lines #34736

Improving copy to clipboard feature- Removing extra lines #34736

ayushtamra commented Jun 30, 2022 •

edited

Loading

linux-foundation-easycla bot commented Jun 30, 2022 •

edited

Loading

k8s-ci-robot commented Jun 30, 2022

k8s-ci-robot commented Jun 30, 2022

netlify bot commented Jun 30, 2022

sftim Jun 30, 2022

ayushtamra Jun 30, 2022 •

edited

Loading

Sea-n commented Aug 29, 2022

ayushtamra commented Aug 29, 2022 •

edited

Loading

tengqm commented Aug 29, 2022

k8s-triage-robot commented Nov 27, 2022

k8s-triage-robot commented Dec 27, 2022

divya-mohan0209 commented Dec 28, 2022

divya-mohan0209 commented Jan 15, 2023

divya-mohan0209 commented Apr 4, 2023

k8s-ci-robot commented Apr 4, 2023

Improving copy to clipboard feature- Removing extra lines #34736

Improving copy to clipboard feature- Removing extra lines #34736

Conversation

ayushtamra commented Jun 30, 2022 • edited Loading

linux-foundation-easycla bot commented Jun 30, 2022 • edited Loading

k8s-ci-robot commented Jun 30, 2022

k8s-ci-robot commented Jun 30, 2022

netlify bot commented Jun 30, 2022

✅ Pull request preview available for checking

sftim Jun 30, 2022

Choose a reason for hiding this comment

ayushtamra Jun 30, 2022 • edited Loading

Choose a reason for hiding this comment

Sea-n commented Aug 29, 2022

ayushtamra commented Aug 29, 2022 • edited Loading

tengqm commented Aug 29, 2022

k8s-triage-robot commented Nov 27, 2022

k8s-triage-robot commented Dec 27, 2022

divya-mohan0209 commented Dec 28, 2022

divya-mohan0209 commented Jan 15, 2023

divya-mohan0209 commented Apr 4, 2023

k8s-ci-robot commented Apr 4, 2023

ayushtamra commented Jun 30, 2022 •

edited

Loading

linux-foundation-easycla bot commented Jun 30, 2022 •

edited

Loading

ayushtamra Jun 30, 2022 •

edited

Loading

ayushtamra commented Aug 29, 2022 •

edited

Loading