Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Update outdated files in dev-1.24-ko.2 (M105-M117) #34919

Merged
merged 1 commit into from
Jul 21, 2022
Merged

[ko] Update outdated files in dev-1.24-ko.2 (M105-M117) #34919

merged 1 commit into from
Jul 21, 2022

Conversation

bconfiden2
Copy link
Member

@bconfiden2 bconfiden2 commented Jul 11, 2022 •
edited
Loading

M105 ~ M117 까지, tutorials 와 관련된 변경사항들을 반영하였습니다!

13 files to be modified

  1. M105. content/en/docs/tutorials/configuration/configure-java-microservice/configure-java-microservice-interactive.html | 1(+XS) 1(-)
  2. M106. content/en/docs/tutorials/configuration/configure-redis-using-configmap.md | 3(+XS) 3(-)
  3. M107. content/en/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive.html | 1(+XS) 1(-)
  4. M108. content/en/docs/tutorials/kubernetes-basics/deploy-app/deploy-interactive.html | 1(+XS) 1(-)
  5. M109. content/en/docs/tutorials/kubernetes-basics/explore/explore-interactive.html | 1(+XS) 1(-)
  6. M110. content/en/docs/tutorials/kubernetes-basics/expose/expose-interactive.html | 1(+XS) 1(-)
  7. M111. content/en/docs/tutorials/kubernetes-basics/expose/expose-intro.html | 1(+XS) 1(-)
  8. M112. content/en/docs/tutorials/kubernetes-basics/scale/scale-interactive.html | 1(+XS) 1(-)
  9. M113. content/en/docs/tutorials/kubernetes-basics/update/update-interactive.html | 1(+XS) 1(-)
  10. M114. content/en/docs/tutorials/security/cluster-level-pss.md | 8(+XS) 5(-)
  11. M115. content/en/docs/tutorials/services/source-ip.md | 3(+XS) 26(-)
  12. M116. content/en/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume.md | 2(+XS) 2(-)
  13. M117. content/en/docs/tutorials/stateful-application/zookeeper.md | 2(+XS) 2(-)

/language ko

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Jul 11, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 11, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bconfiden2 / name: Sang Hong, Kim (b68e7c5)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 11, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @bconfiden2!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 11, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 11, 2022
@jihoon-seo
Copy link
Member

@bconfiden2 첫 기여 감사드리며 환영합니다~~
@seokho-son 님, dev-1.24-ko.2 브랜치에 대해 Netlify build 설정이 안 되어 있는 것 같습니다~ 확인 부탁 드려요 😊

@seokho-son
Copy link
Member

앗! Netlify 설정이 이상하게 되어있었군요. 감사합니다. 수정했습니다. 😀

@bconfiden2
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@bconfiden2: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seokho-son
Copy link
Member

(추가 커밋 등 커밋에 변경이 있어야 프리뷰 빌드가 신규로 진행됩니다 ㅠ)

@bconfiden2
Copy link
Member Author

#34385 (comment) 에 댓글 남겨주신 것 처럼,
영향이 가지 않을 선에서 커밋을 추가하여 기존 커밋에 squash 한 뒤 (force-)push 하면 될까요??

jihoon-seo
jihoon-seo reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bconfiden2 네 맞습니다.
(예를 들면 아래 사항을) 반영하시고 squash, force-push 하시면 Netlify build가 trigger될 것 같습니다. 😊

content/ko/docs/tutorials/services/source-ip.md Outdated
@@ -206,19 +206,7 @@ client_address=10.240.0.3

시각적으로
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated 처리와는 별개이기는 하지만 눈에 띄어서.. 😊

[원문]

Visually:

Suggested change
시각적으로
이를 그림으로 표현하면 다음과 같다.

L207, L263, L327 총 3곳입니다. 😊

@bconfiden2 bconfiden2 force-pushed the 220711_Update_outdated_dev-1.24-ko.2_M105-M117 branch from b68e7c5 to b635290 Compare July 11, 2022 23:47
@netlify
Copy link

netlify bot commented Jul 11, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit f04ca62
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62d8908842daa40009260cd7
😎 Deploy Preview https://deploy-preview-34919--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bconfiden2 bconfiden2 force-pushed the 220711_Update_outdated_dev-1.24-ko.2_M105-M117 branch from b635290 to 5f44e8b Compare July 18, 2022 04:59
@bconfiden2
Copy link
Member Author

영문 문서와 라인 수 맞춰서 다시 푸시하였습니다!

seokho-son
seokho-son reviewed Jul 20, 2022
View reviewed changes
content/ko/docs/tutorials/services/source-ip.md Outdated
{{</ mermaid >}}
이를 그림으로 표현하면 다음과 같다.

{{< figure src="/docs/images/tutor-service-nodePort-fig01.svg" alt="source IP nodeport figure 01" class="diagram-large" caption="Figure. Source IP Type=NodePort using SNAT" link="https://mermaid.live/edit#pako:eNqNkV9rwyAUxb-K3LysYEqS_WFYKAzat9GHdW9zDxKvi9RoMIZtlH732ZjSbE970cu5v3s86hFqJxEYfHjRNeT5ZcUtIbXRaMNN2hZ5vrYRqt52cSXV-4iMSuwkZiYtyX739EqWaahMQ-V1qPxDVLNOvkYrO6fj2dupWMR2iiT6foOKdEZoS5Q2hmVSStoH7w7IMqXUVOefWoaG3XVftHbGeZYVRbH6ZXJ47CeL2-qhxvt_ucTe1SUlpuMN6CX12XeGpLdJiaMMFFr0rdAyvvfxjHEIDbbIgcVSohKDCRy4PUV06KQIuJU6OA9MCdMjBTEEt_-2NbDgB7xAGy3i97VJPP0ABRmcqg" >}}
Copy link
Member

@seokho-son seokho-son Jul 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< figure src="/docs/images/tutor-service-nodePort-fig01.svg" alt="source IP nodeport figure 01" class="diagram-large" caption="Figure. Source IP Type=NodePort using SNAT" link="https://mermaid.live/edit#pako:eNqNkV9rwyAUxb-K3LysYEqS_WFYKAzat9GHdW9zDxKvi9RoMIZtlH732ZjSbE970cu5v3s86hFqJxEYfHjRNeT5ZcUtIbXRaMNN2hZ5vrYRqt52cSXV-4iMSuwkZiYtyX739EqWaahMQ-V1qPxDVLNOvkYrO6fj2dupWMR2iiT6foOKdEZoS5Q2hmVSStoH7w7IMqXUVOefWoaG3XVftHbGeZYVRbH6ZXJ47CeL2-qhxvt_ucTe1SUlpuMN6CX12XeGpLdJiaMMFFr0rdAyvvfxjHEIDbbIgcVSohKDCRy4PUV06KQIuJU6OA9MCdMjBTEEt_-2NbDgB7xAGy3i97VJPP0ABRmcqg" >}}
{{< figure src="/docs/images/tutor-service-nodePort-fig01.svg" alt="source IP nodeport figure 01" class="diagram-large" caption="그림. Source IP Type=NodePort using SNAT" link="https://mermaid.live/edit#pako:eNqNkV9rwyAUxb-K3LysYEqS_WFYKAzat9GHdW9zDxKvi9RoMIZtlH732ZjSbE970cu5v3s86hFqJxEYfHjRNeT5ZcUtIbXRaMNN2hZ5vrYRqt52cSXV-4iMSuwkZiYtyX739EqWaahMQ-V1qPxDVLNOvkYrO6fj2dupWMR2iiT6foOKdEZoS5Q2hmVSStoH7w7IMqXUVOefWoaG3XVftHbGeZYVRbH6ZXJ47CeL2-qhxvt_ucTe1SUlpuMN6CX12XeGpLdJiaMMFFr0rdAyvvfxjHEIDbbIgcVSohKDCRy4PUV06KQIuJU6OA9MCdMjBTEEt_-2NbDgB7xAGy3i97VJPP0ABRmcqg" >}}

caption 부분도 한글화 가능해보입니다.
꼭 해당 PR에서 해결할 필요는 없어보입니다. :)

seokho-son
seokho-son reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bconfiden2
Thank you for the contribution !!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d2f0fc3074bec9f54a3da87429b693832d0aa9fb

@bconfiden2 bconfiden2 force-pushed the 220711_Update_outdated_dev-1.24-ko.2_M105-M117 branch from 5f44e8b to f04ca62 Compare July 20, 2022 23:32
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@bconfiden2
Copy link
Member Author

bconfiden2 commented Jul 20, 2022 •
edited
Loading

아직 approve 되지 않아서 변경사항 바로 반영하였고, 아래쪽에 있던 또다른 캡션 부분도 같이 변경하였습니다!!
/assign @seokho-son

푸시하니까 lgtm 이 제거되네요... 😲 리뷰어가 lgtm을 붙인 뒤에는 수정하지 않는게 좋을까요??

@seokho-son
Copy link
Member

아직 approve 되지 않아서 변경사항 바로 반영하였고, 아래쪽에 있던 또다른 캡션 부분도 같이 변경하였습니다!! /assign @seokho-son

푸시하니까 lgtm 이 제거되네요... 😲 리뷰어가 lgtm을 붙인 뒤에는 수정하지 않는게 좋을까요??

@bconfiden2

  • 신규 푸시가 있으면 lgtm 레이블이 제거되도록 설정되어 있습니다.
  • 수정하셔도 괜찮습니다! :0
  • 제가 lgtm을 단 이유는 기존 상태로도 looks good to me 였기 때문입니다! ㅎㅎ
  • 해당 컨밴션?은 한글화뿐만 아니라 영문 업스트림쪽에서도 동일하다고 보시면 됩니다.
    • lgtm 레이블이 붙은 상황 마다 다르긴 하고, 필요하다면 업데이트해도 된다는 것을 의미합니다. 업데이트하면, 업데이트된 내용에 대해서도 리뷰어 및 승인자가 다시 확인하겠지요?

@seokho-son
Copy link
Member

I am happy to approve your first contribution @bconfiden2
Thanks !

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 66937dc087a0b631a52a6963baf13a1b5df95a7a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit dd111ea into kubernetes:dev-1.24-ko.2 Jul 21, 2022
@bconfiden2 bconfiden2 deleted the 220711_Update_outdated_dev-1.24-ko.2_M105-M117 branch July 26, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo jihoon-seo left review comments

@gochist gochist Awaiting requested review from gochist

@jmyung jmyung Awaiting requested review from jmyung

@seokho-son seokho-son Awaiting requested review from seokho-son

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bconfiden2 @k8s-ci-robot @jihoon-seo @seokho-son