Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ko] Update outdated files in dev-1.24-ko.2 'M118-M125' #35022

Closed

Conversation

Veryfirstmoment
Copy link
Contributor

안녕하세요,
M118-M125에 해당하는, examples, includes, releases 폴더의 변경사항을 적용했습니다.

Related issue: Outdated Korean contents in the dev-1.24-ko.2 #34903

8 files to be modified

  • M118. content/en/examples/application/mysql/mysql-configmap.yaml | 1(+XS) 2(-)
  • M119. content/en/examples/application/mysql/mysql-services.yaml | 3(+XS) 0(-)
  • M120. content/en/examples/application/mysql/mysql-statefulset.yaml | 2(+XS) 0(-)
  • M121. content/en/examples/controllers/job.yaml | 1(+XS) 1(-)
  • M122. content/en/examples/pods/pod-with-affinity-anti-affinity.yaml | 4(+XS) 3(-)
  • M123. content/en/includes/task-tutorial-prereqs.md | 1(+XS) 1(-)
  • M124. content/en/releases/_index.md | 2(+XS) 2(-)
  • M125. content/en/releases/version-skew-policy.md | 32(+M) 32(-)

/language ko

@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Jul 14, 2022
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 14, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Veryfirstmoment / name: Shine (1fde7d1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 14, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Veryfirstmoment!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign claudiajkang after the PR has been reviewed.
You can assign the PR to them by writing /assign @claudiajkang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 14, 2022
@netlify
Copy link

netlify bot commented Jul 14, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a0f06a9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62d4ca2ea6bca500093f402e
😎 Deploy Preview https://deploy-preview-35022--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Member

@Veryfirstmoment 기여 감사합니다!! :) 첫 기여를 환영합니다!

한글화는 #34901 에 따라
현재 dev-1.24-ko.2 branch 에서 진행되고 있습니다. 그리고 outdated update 는 해당 개발 브랜치에서만 진행합니다.

그래서~ 해당 기여를 하실 때는

로컬 작업 환경에서 dev-1.24-ko.2 를 기준으로 작업을 시작해서
PR 오픈시에도 dev-1.24-ko.2를 target으로 해야 합니다. :)

현재는 로컬 환경에서 main branch 를 기준으로 작업을 시작하셨고,
작업하신 내용을 다신 main branch 에 머지하려는 PR을 오픈하시 상태입니다.

이 상황에서는 커밋들을 조정하는 것도 방법일 수 있지만,
작업을 다시하여 PR을 오픈하는 것이 더 편할 수 있습니다.

dev-1.24-ko.2를 기준으로 작업하시려면, 아래와 같이 진행하시면 됩니다.
(혹시 모르실 수도 있으니 예시를 간략히 공유 드립니다.)

(upstream은 https://github.com/kubernetes/website 을 뜻함)

  • git fetch upstream
  • git checkout upstream/dev-1.24-ko.2
  • git checkout -b outdated-dev-1.24-ko.2
  • 기존 수정을 재반영
  • git add&commit
  • git push origin outdated-dev-1.24-ko.2
  • PR 오픈시 upstream쪽 target(base) branch를 dev-1.24-ko.2 로 지정

@Veryfirstmoment
Copy link
Contributor Author

@seokho-son 님, 자세히 설명해주셔서 감사합니다. 다시 한번 진행하게습니다.

@Veryfirstmoment
Copy link
Contributor Author

Veryfirstmoment commented Jul 18, 2022

#35126에 수정하여 새로 올렸습니다.

@seokho-son
Copy link
Member

@Veryfirstmoment
새로 오픈한 PR 정보 공유 감사합니다! ;)

/close

@k8s-ci-robot
Copy link
Contributor

@seokho-son: Closed this PR.

In response to this:

@Veryfirstmoment
새로 오픈한 PR 정보 공유 감사합니다! ;)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Veryfirstmoment Veryfirstmoment deleted the shine_dev-1.24-ko.2 branch August 9, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants