Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update outdated controllers/job in dev-1.24-ko.2 (M40) #35721

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Update outdated controllers/job in dev-1.24-ko.2 (M40) #35721

merged 1 commit into from
Aug 6, 2022

Conversation

seokho-son
Copy link
Member

Signed-off-by: Seokho Son shsongist@gmail.com

Resolve a task (M40) in #34903

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2022
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 5, 2022
@seokho-son seokho-son mentioned this pull request Aug 5, 2022
Closed
@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 994ec83
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62ecb6da2402000009318551
😎 Deploy Preview https://deploy-preview-35721--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

yoonian
yoonian reviewed Aug 5, 2022
View reviewed changes
Copy link
Contributor

@yoonian yoonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seokho-son 탭만 어떻게 하면 좋을듯요.

content/ko/docs/concepts/workloads/controllers/job.md Outdated
출력 결과는 다음과 같다.

```
{{< tabs name="잡 상태 확인" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{< tabs name="잡 상태 확인" >}}
{{< tabs name="Check status of Job" >}}

한글로 하는 것이 좋긴한데, 렌더링된 페이지에서는 탭이 안 먹히네요. 영문으로 해야 할듯 한 느낌입니다.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoonian 확인 감사합니다! :)
영어로 변경하였고, 로컬 빌드해서 확인 완료했습니다. (+스쿼싱)

@seokho-son
Copy link
Member Author

@kubernetes/sig-docs-ko-reviews
해당 PR은 마일스톤 정리를 위해~ 빠른 리뷰 및 승인이 필요합니다. :)

@seokho-son
Update outdated controllers/job in dev-1.24-ko.2(M40)
994ec83 
Signed-off-by: Seokho Son <shsongist@gmail.com>
@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 502b80c13907bb0153f8cb63abc0d4e094a4d075

@seokho-son
Copy link
Member Author

PTAL @jihoon-seo

@jihoon-seo
Copy link
Member

@seokho-son @yoonian 감사합니다~~
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 248922a into kubernetes:dev-1.24-ko.2 Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoonian yoonian yoonian left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@pjhwa pjhwa Awaiting requested review from pjhwa

Assignees

@yoonian yoonian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seokho-son @yoonian @k8s-ci-robot @jihoon-seo