Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko]Update outdated controllers/replicaset in dev-1.24-ko.2(M41) #35731

Merged
merged 2 commits into from
Aug 7, 2022
Merged

[ko]Update outdated controllers/replicaset in dev-1.24-ko.2(M41) #35731

merged 2 commits into from
Aug 7, 2022

Conversation

gy-ulbak96
Copy link
Contributor

@gy-ulbak96 gy-ulbak96 commented Aug 5, 2022 •
edited by seokho-son
Loading

Signed-off-by: gy-ulbak96 rbfl9611@gmail.com
Resolve a task (M41) in #34903

@gy-ulbak96
[ko]Update outdated controllers/replicaset in dev-1.24-ko.2(M41)
c8ed7d6 
Signed-off-by: gy-ulbak96 <rbfl9611@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 5, 2022
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 5, 2022
@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 840ef7f
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62eda7814a77f700093cc591
😎 Deploy Preview https://deploy-preview-35731--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

seokho-son
seokho-son reviewed Aug 5, 2022
View reviewed changes
content/ko/docs/concepts/workloads/controllers/replicaset.md Outdated
Comment on lines 2 to 5
reviewers:
- Kashomon
- bprashanth
- madhusudancs
Copy link
Member

@seokho-son seokho-son Aug 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reviewers:
- Kashomon
- bprashanth
- madhusudancs
# reviewers:
# - Kashomon
# - bprashanth
# - madhusudancs

이 부분은 주석 처리해주시면 됩니다. :)

@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022

@gy-ulbak96
390줄에

 A ReplicaSet delegates local container restarts to some agent on the node (for example, Kubelet or Docker).

이 다음과 같이 바뀌었는데,

A ReplicaSet delegates local container restarts to some agent on the node such as Kubelet.

아직 아래 같은 걸 보니, 번역이 안된 것 같습니다?

레플리카셋은 로컬 컨테이너의 재시작을 노드에 있는 어떤 에이전트에게 위임한다(예를들어 Kubelet 또는 도커).

@seokho-son
Copy link
Member

@gy-ulbak96 님~

@yoonian 께서 확인해주신 것과 같이, 390줄 마지막 문장에 누락된 사항이 있네요.
대략 아래 정도의 내용으로 간단히 업데이트하면 될 것 같습니다. 참고하시기 바랍니다. :)

- 어떤 에이전트에게 위임한다(예를들어 Kubelet 또는 도커).
+ Kubelet과 같은 에이전트에게 위임한다.

@gy-ulbak96
Copy link
Contributor Author

확인하여 수정했습니다. 감사합니다 ~ :)

@yoonian
Copy link
Contributor

yoonian commented Aug 5, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a4c6f52cb1321a95667df4a33b3f6a31c15acd5

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2022
@jihoon-seo
Copy link
Member

@gy-ulbak96 님~~ 리뷰의견 반영까지 해 주셔서 감사합니다~~
현재 이 PR에 2개의 커밋이 속해 있는데요,
이를 1개의 커밋으로 squash 해 주실 수 있을까요? 😊
(Squash 방법은 https://jinnypark9393.github.io/devops/Github_Git_Rebase_Squash/ 를 참고하시면 될 것 같습니다 😊)

@yoonian
Copy link
Contributor

yoonian commented Aug 6, 2022

안보이는 것 같아서 https://ehdals9412.tistory.com/48 요런 거 참고하시죠.

@seokho-son
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 7, 2022
@seokho-son
Copy link
Member

감사합니다!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2b62a3a into kubernetes:dev-1.24-ko.2 Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

Assignees

@seokho-son seokho-son

@yoonian yoonian

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gy-ulbak96 @yoonian @seokho-son @k8s-ci-robot @jihoon-seo