Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guidance for reviewers about squashing commits #36364

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Add guidance for reviewers about squashing commits #36364

merged 1 commit into from
Mar 27, 2023

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Aug 28, 2022

Fixes #36294

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 28, 2022
@netlify
Copy link

netlify bot commented Aug 28, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cb1a807
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64217f231cb8370008039f25
😎 Deploy Preview https://deploy-preview-36364--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rolfedh rolfedh force-pushed the rvwr-sqsh-cmmts branch 2 times, most recently from 124aaa2 to 47cd2f9 Compare August 28, 2022 14:44
@rolfedh
Copy link
Contributor Author

rolfedh commented Aug 28, 2022 •
edited
Loading

@mengjiao-liu @sftim rough draft.

@rolfedh rolfedh force-pushed the rvwr-sqsh-cmmts branch 4 times, most recently from 443404d to ef2aba1 Compare August 28, 2022 18:08
@rolfedh rolfedh mentioned this pull request Sep 7, 2022
Closed
9 tasks
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 26, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 26, 2022
@divya-mohan0209
Copy link
Contributor

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 16, 2023
divya-mohan0209
divya-mohan0209 requested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits.

content/en/docs/contribute/review/for-approvers.md Outdated Show resolved Hide resolved
content/en/docs/contribute/review/for-approvers.md Outdated Show resolved Hide resolved
@kbhawkey
Copy link
Contributor

Hey @rolfedh . Are you actively working on the changes in this pull request?
If not, I can close the PR.
Thanks

@rolfedh
Copy link
Contributor Author

rolfedh commented Feb 21, 2023

Hey @rolfedh . Are you actively working on the changes in this pull request? If not, I can close the PR. Thanks

@kbhawkey: Thanks for the heads-up. Please leave this PR open. I didn't realize it had received a review. I'll update it soon so we can get it merged.

@natalisucks
Copy link
Contributor

Hi @rolfedh! I'm providing another friendly ping on this PR. I understand you want to leave it open to review, so this is just a reminder as per PR Wrangling efforts. Thanks for your work so far! 👏

@rolfedh rolfedh requested review from divya-mohan0209 and removed request for bradtopol March 21, 2023 01:57
@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 21, 2023

Hi @divya-mohan0209. Thanks for your comments. I've updated the PR and would appreciate your approval/merge. Rolfe

@natalisucks
Copy link
Contributor

@rolfedh I'd like to check that this should no longer be considered a work in progress? If so, I'd retitle the PR and remove the label. Also, you'll want to push an empty commit to retrigger the checks that are failing.

/remove do-not-merge/work-in-progress

@rolfedh rolfedh changed the title [WIP] Add guidance for reviewers about squashing commits Add guidance for reviewers about squashing commits Mar 21, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2023
@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 22, 2023

Thanks for the guidance, @natalisucks. I think this is ready for merge.

@natalisucks
Copy link
Contributor

Thanks @rolfedh! 🤘
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 72325348bc074c8f0b8bc1bc6f26e021432a5025

divya-mohan0209
divya-mohan0209 reviewed Mar 25, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a single suggestion and I'd be happy to approve this PR, once that is committed.

content/en/docs/contribute/review/for-approvers.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
divya-mohan0209
divya-mohan0209 reviewed Mar 27, 2023
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a28e91601c87d1e2fae62c7a1c3735faab7460b1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3ea769c into kubernetes:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 requested changes

@natalisucks natalisucks Awaiting requested review from natalisucks

Assignees

@natalisucks natalisucks

@divya-mohan0209 divya-mohan0209

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add guidance for reviewers about squashing commits
6 participants
@rolfedh @k8s-triage-robot @divya-mohan0209 @kbhawkey @natalisucks @k8s-ci-robot