Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup after 1.25 release and add nate-double-u as reviewer #37152

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

reylejano
Copy link
Member

@reylejano reylejano commented Oct 4, 2022

This PR does the following:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 4, 2022
@reylejano
Copy link
Member Author

/assign @natalisucks @divya-mohan0209

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 4, 2022
@reylejano reylejano changed the title Cleanup after 1.25 release and add nate as reviewer Cleanup after 1.25 release and add nate-double-u as reviewer Oct 4, 2022
@netlify
Copy link

netlify bot commented Oct 4, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit 73b9bfb
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/633c7ca29733d70008bfe995
😎 Deploy Preview https://deploy-preview-37152--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@natalisucks
Copy link
Contributor

/lgtm
Thanks Rey!

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5517f27bcc0efb73c27ff12713c043546e60b5e8

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2022
@sftim
Copy link
Contributor

sftim commented Oct 5, 2022

/approve

(consider doing a change like this as 2 commits @reylejano just in case it turns out we want to revert one of the changes due to, eg, a typo)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9d625f4 into kubernetes:main Oct 5, 2022
@reylejano reylejano deleted the add-nate-reviewers branch October 5, 2022 15:19
@nate-double-u
Copy link
Contributor

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants