Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nate Waddington as an approver for docs #37475

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

natalisucks
Copy link
Contributor

As Nate is a blog approver and will now be doing PR Wrangling, he needs to be added to our approver list to unlock this work.

Congratulations, Nate! 🎉

@reylejano @sftim @divya-mohan0209

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 24, 2022
@reylejano
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eaa2bc3c6d99ca4c0c777a8781c5f217a00af3ad

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@netlify
Copy link

netlify bot commented Oct 24, 2022

Pull request preview available for checking

Name Link
🔨 Latest commit a62fbc7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6356b5785688af00091275e0
😎 Deploy Preview https://deploy-preview-37475--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot merged commit 13a965a into kubernetes:main Oct 24, 2022
@sftim
Copy link
Contributor

sftim commented Oct 24, 2022

I'm not sure if I understand the logic here (blog approvers don't need to be website approvers), but I am nonetheless happy to see Nate become an approver for the English localization.

@nate-double-u
Copy link
Contributor

Thanks! (love that the bot asked me to review 😅)

@natalisucks
Copy link
Contributor Author

@sftim Apologies Tim, this information was provided additionally on top of Nate having shadowed PR Wrangling for a while, in terms of further strengthening his growth to approver (as opposed to this being the reason). Great to hear this has your support!

@nate-double-u
Copy link
Contributor

The chat that @reylejano and I had about PR #37152 was to add me as an approver, not only a reviewer. This PR corrects that and allows me to /approve and be on the wrangling team 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants