-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nate Waddington as an approver for docs #37475
Conversation
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: eaa2bc3c6d99ca4c0c777a8781c5f217a00af3ad
|
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm not sure if I understand the logic here (blog approvers don't need to be website approvers), but I am nonetheless happy to see Nate become an approver for the English localization. |
Thanks! (love that the bot asked me to review 😅) |
@sftim Apologies Tim, this information was provided additionally on top of Nate having shadowed PR Wrangling for a while, in terms of further strengthening his growth to approver (as opposed to this being the reason). Great to hear this has your support! |
The chat that @reylejano and I had about PR #37152 was to add me as an approver, not only a reviewer. This PR corrects that and allows me to |
As Nate is a blog approver and will now be doing PR Wrangling, he needs to be added to our approver list to unlock this work.
Congratulations, Nate! 🎉
@reylejano @sftim @divya-mohan0209