Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote "Retriable and non-retriable pod failures for Jobs" to Beta #37242

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Promote "Retriable and non-retriable pod failures for Jobs" to Beta #37242

merged 2 commits into from
Nov 18, 2022

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 10, 2022 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.26 milestone Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 10, 2022
@netlify
Copy link

netlify bot commented Oct 10, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 1e4a160
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6373bf6541c8e5000852faa8

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 10, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2022
@mimowo mimowo force-pushed the retriable-pod-failures-beta branch 2 times, most recently from f693866 to 4562a4f Compare November 2, 2022 08:10
@mimowo mimowo changed the title Retriable pod failures for Jobs beta [placeholder] Retriable pod failures for Jobs beta Nov 2, 2022
@mimowo mimowo changed the title Retriable pod failures for Jobs beta Promote "Retriable and non-retriable pod failures for Jobs" to Beta Nov 2, 2022
@mimowo mimowo mentioned this pull request Nov 2, 2022
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2022
@mimowo mimowo marked this pull request as ready for review November 10, 2022 15:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2022
@mimowo mimowo force-pushed the retriable-pod-failures-beta branch 2 times, most recently from b395d2a to e75cefa Compare November 10, 2022 16:08
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2022
@mimowo
Copy link
Contributor Author

mimowo commented Nov 11, 2022

/assign @sftim

@mimowo
Copy link
Contributor Author

mimowo commented Nov 14, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 14, 2022
sftim
sftim reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change min-kubernetes-server-version in content/en/docs/tasks/job/pod-failure-policy.md?

I typically add some wording saying that if you're running an older version of Kubernetes, to switch to the docs for that version.

@mimowo
Copy link
Contributor Author

mimowo commented Nov 14, 2022

Do we need to change min-kubernetes-server-version in content/en/docs/tasks/job/pod-failure-policy.md?

I think the min-kubernetes-server-version should stay as is, because 1.25 is the version in which this feature was introduced. In particular this tutorial would work both on 1.25 and 1.26. However, I updated the FEATURE STATE to 1.26 and beta.

I typically add some wording saying that if you're running an older version of Kubernetes, to switch to the docs for that version.

Where would be the appropriate place to mention that? Could you maybe point to an example?

Also, there are two main differences between 1.25 and 1.26:

cortespao
cortespao reviewed Nov 14, 2022
View reviewed changes
Copy link
Contributor

@cortespao cortespao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions.
Thanks!

content/en/docs/concepts/workloads/pods/disruptions.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/pods/disruptions.md Show resolved Hide resolved
content/en/docs/concepts/workloads/controllers/job.md Outdated Show resolved Hide resolved
@mimowo mimowo force-pushed the retriable-pod-failures-beta branch 2 times, most recently from f96cb88 to c78a664 Compare November 14, 2022 17:41
@mimowo @sftim @cortespao
Update of the docs for Beta
163e53d 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Paola Cortés <51036950+cortespao@users.noreply.github.com>
@mimowo
Copy link
Contributor Author

mimowo commented Nov 15, 2022

Do we need to change min-kubernetes-server-version in content/en/docs/tasks/job/pod-failure-policy.md?

Added a not the disruptions.md to refer to the older version of the docs for older versions of k8s. Please take a look.

sftim
sftim reviewed Nov 15, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for SIG Docs.

Tech review LGTM needed from SIG Node.

content/en/docs/concepts/workloads/pods/disruptions.md Outdated Show resolved Hide resolved
@mimowo
Copy link
Contributor Author

mimowo commented Nov 15, 2022

/assign @bobbypage
could you please provide a technical review for the doc update from sig-node POV?

SergeyKanzhelev
SergeyKanzhelev approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: abb2755df46a54a8377f0ea59f08725907d23252

@mimowo
Copy link
Contributor Author

mimowo commented Nov 16, 2022

LGTM for SIG Docs.

Tech review LGTM needed from SIG Node.

@sftim The PR is now lgtm-ed by Sergey from SIG-Node.

@reylejano
Copy link
Member

Preview of updated pages:

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022
@k8s-ci-robot k8s-ci-robot merged commit bfe7bd6 into kubernetes:dev-1.26 Nov 18, 2022
@alculquicondor alculquicondor mentioned this pull request Nov 23, 2022
Merged
@Zhuzhenghao Zhuzhenghao mentioned this pull request Jan 24, 2023
Merged
@mimowo mimowo deleted the retriable-pod-failures-beta branch March 18, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@cortespao cortespao cortespao left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@davidopp davidopp Awaiting requested review from davidopp

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@bobbypage bobbypage

@SergeyKanzhelev SergeyKanzhelev

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.26
Development

Successfully merging this pull request may close these issues.
7 participants
@mimowo @k8s-ci-robot @reylejano @SergeyKanzhelev @sftim @cortespao @bobbypage