Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add dynamic resource allocation feature blog post #37434

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Oct 21, 2022

Assuming that the feature goes into 1.26 as alpha, this will become a blog post about it.

kubernetes/enhancements#3063

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Oct 21, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2022
@netlify
Copy link

netlify bot commented Oct 21, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 7008f54
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/638f6b168b62b40008011fce
😎 Deploy Preview https://deploy-preview-37434--kubernetes-io-main-staging.netlify.app/blog/2022/12/15/dynamic-resource-allocation
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 16, 2022

Hello @pohly , v1.26 Comms lead here. This feature blog is on a feature tracked for release, the deadline for submitting a draft is the 29th of November; this should be considered the hard limit since we will need to review/edit/discuss the draft, so if at all possible it's better to submit it earlier to avoid any problems.

Any doubts, we're here to help!

@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 24, 2022

Hello @pohly , we're doing a global reminder about submitting a draft for review for all opted-in feature blogs. If it's at all possible, it is very helpful for the release team to have drafts submitted for review before the hard deadline date, to better plan the release dates and avoid missing out. Thank you!

@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from 46f6c06 to ccfa6fc Compare November 29, 2022 11:35
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2022
@pohly pohly changed the title WIP: blog: add dynamic resource allocation feature blog post blog: add dynamic resource allocation feature blog post Nov 29, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2022
@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from ccfa6fc to f3ac606 Compare November 29, 2022 11:57
Copy link
Contributor

@klueska klueska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick pass

content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from 085461e to 794954c Compare November 29, 2022 16:52
@pohly
Copy link
Contributor Author

pohly commented Nov 29, 2022

I've pushed the update: https://github.com/kubernetes/website/compare/085461ea8fd98fc7111fe9754a2889cff5bd72c2..794954c5a0f4306d8441194cc235daecfdd2e9fc - please ignore the unrelated blog post, I rebased accidentally instead of just squashing.

content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
In another terminal, run the kubelet plugin:

```console
$ sudo mkdir -p /var/run/cdi && sudo chmod a+rwx /var/run/cdi /var/lib/kubelet/plugins_registry /var/lib/kubelet/plugins/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be part of the "setup" script from above.

Independently, are these three necessary? I have never needed to do this in my environment:

sudo chmod a+rwx /var/run/cdi
sudo chmod a+rwx /var/lib/kubelet/plugins_registry
sudo chmod a+rwx /var/lib/kubelet/plugins/

If those are not actually necessary, then the whole setup script would be:

$ cat run-k8s.sh
#!/usr/bin/env bash

sudo rm -rf /tmp/kube*
sudo rm -rf /var/run/kubernetes

sudo mkdir -p /var/run/cdi

export RUNTIME_CONFIG=resource.k8s.io/v1alpha1
export FEATURE_GATES=DynamicResourceAllocation=true 
export DNS_ADDON="coredns" 
export CGROUP_DRIVER=systemd 
export CONTAINER_RUNTIME_ENDPOINT=unix:///var/run/crio/crio.sock 
export LOG_LEVEL=6 
export ENABLE_CSI_SNAPSHOTTER=false 
export API_SECURE_PORT=6444 
export ALLOW_PRIVILEGED=1 
export PATH=$(pwd)/third_party/etcd:$PATH
./hack/local-up-cluster.sh -O

Where you then run:

$ hack/install-etcd.sh
...
$ ./run-k8s.sh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never needed to do this in my environment:|

Are you running the "go" command with the kubelet plugin as root? Then it is not needed. But when using a non-privileged user account it is necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never tried to run things exactly as you described here. I always deploy privileged pods, so that probably explains it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, would it make sense to just have them run the go command as sudo so as not to corrupt their environment for future "real" deployments of the components as pods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running "sudo go", it will not use the already populated Go cache of the current user. Let me add that as explanation and also point out that permissions should get restored when done.

@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from eee479b to 8220c8b Compare November 29, 2022 21:02
@pohly
Copy link
Contributor Author

pohly commented Nov 29, 2022

Another update...

@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from 8220c8b to d9de2ca Compare November 29, 2022 21:04
@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from d9de2ca to 0a23be1 Compare November 30, 2022 08:28
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from d0a93fe to f41da92 Compare November 30, 2022 11:12
@fsmunoz
Copy link
Contributor

fsmunoz commented Nov 30, 2022

Hello, Comms Lead for v1.26 here: this Feature Blog PR is confirmed for the post-release Feature Blog series. We will add the publishing date in the next days. Thank you for your work!

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 2, 2022

Hello, Comms Lead for v1.26 here. The publication order and date for the Feature Blog series has been finalised and the tracking board updated (cf. discussion).

The publication date for this article is 15-12-2022 (December 15).

Thanks!

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

This is a big change to Kubernetes and so, not unrelated, I have a lot of feedback. My hope is that every comment is useful.

Anything I've called out as a question or a nit is an opportunity for you to revise things, but not a mandate. It'd be good to at least get an answer for each question I've asked. I know there were quite a few.

content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/data-tbd/index.md Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Dec 6, 2022

Please prioritize setting the publication date to the 15th of December, and change content/en/blog/_posts/data-tbd/index.md to match. All other feedback is less important (but you should still account for it).

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 6, 2022

Holding until the release day.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2022
@pohly
Copy link
Contributor Author

pohly commented Dec 6, 2022

I'll squash and rename once we are done with the review.

@sftim
Copy link
Contributor

sftim commented Dec 6, 2022

Please prioritize setting the publication date to the 15th of December, and change content/en/blog/_posts/data-tbd/index.md to match. All other feedback is less important (but you should still account for it).

We'd like to get this as close as possible to being good to publish. We don't have to clear every feedback item to be able to merge, but we do have to get the date right.

@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from 10a0937 to 05f2826 Compare December 6, 2022 14:43
@pohly
Copy link
Contributor Author

pohly commented Dec 6, 2022

I've renamed the file to content/en/blog/_posts/2022-12-15-dynamic-resource-allocation-alpha/index.md and squashed.

@sftim
Copy link
Contributor

sftim commented Dec 6, 2022

/approve
LGTM

Not adding formal LGTM yet as there are some bits of feedback pending. However, we could merge this as-is if need be.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@pohly pohly force-pushed the dynamic-resource-allocation-alpha-feature-blog-post branch from 1ce66ee to 7008f54 Compare December 6, 2022 16:17
@sftim
Copy link
Contributor

sftim commented Dec 6, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a198af050cf8288577990331561569a7f069b6b5

@sftim
Copy link
Contributor

sftim commented Dec 6, 2022

OK to unhold once Kubernetes v1.26 is released

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 7, 2022

Marking this Ready for Publishing in Comms tracking, thank you for all the work - minor edits/reviews are still doable until the release date.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, klueska, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fsmunoz
Copy link
Contributor

fsmunoz commented Dec 10, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 694c4f7 into kubernetes:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

5 participants