Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design doc reference link of PLEG #37745

Closed
wants to merge 2 commits into from

Conversation

nishipy
Copy link
Contributor

@nishipy nishipy commented Nov 7, 2022

After #17596, the link of the PLEG design doc is moved to https://github.com/kubernetes/design-proposals-archive/blob/main/node/pod-lifecycle-event-generator.md. Therefore, currently it is outdated and it returns a 404 response.

This PR updates the link of that and fixes it.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign butuzov, dianaabv, inductor for approval by writing /assign @butuzov @dianaabv @inductor in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/ja Issues or PRs related to Japanese language labels Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 7, 2022
@netlify
Copy link

netlify bot commented Nov 7, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fd0f202
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/636879fca4b63f00098f2144
😎 Deploy Preview https://deploy-preview-37745--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shurup
Copy link
Member

shurup commented Nov 7, 2022

As far as I can see in the actual version of this page in English (this page is even more relevant now), PLEG is not mentioned anymore. Thus the reason for these outdated links is that these translations are outdated compared to the original (English) version of the page.

@reylejano
Copy link
Member

Please keep one PR per localization
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@MaxymVlasov
Copy link
Member

/remove-label language-uk
Because it was decoupled and already merged by #38953

@k8s-ci-robot
Copy link
Contributor

@MaxymVlasov: The label(s) /remove-label language-uk cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label language-uk
Because it was decoupled and already merged by #38953

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MaxymVlasov
Copy link
Member

/remove-label language/uk
Because it was decoupled and already merged by #38953

@k8s-ci-robot
Copy link
Contributor

@MaxymVlasov: The label(s) /remove-label language/uk cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/remove-label language/uk
Because it was decoupled and already merged by #38953

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Jan 17, 2023

This PR still includes changes to Ukrainian. Until that changes, we should retain the label for Ukrainian.

Also, even if you add a commit that undoes those changes, the interim commits mean that the label should stay. You'd need to squash it down to 1 commit to address that.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2023
@nishipy
Copy link
Contributor Author

nishipy commented Apr 18, 2023

Would it better if I re-create PRs for each language separately(ja, ru, uk)?

@sftim
Copy link
Contributor

sftim commented Apr 18, 2023

Would it better if I re-create PRs for each language separately (ja, ru, uk)?

Yes please.

@nishipy
Copy link
Contributor Author

nishipy commented Apr 18, 2023

I've created new PRs #40753 and #40754 for each localization, so this PR will be closed.

@nishipy nishipy closed this Apr 18, 2023
@nishipy nishipy deleted the fix-pleg-link branch April 18, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/ja Issues or PRs related to Japanese language language/ru Issues or PRs related to Russian language language/uk Issues or PRs related to Ukrainian language lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants