Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] add docs for finalizers #38768

Merged
merged 1 commit into from
Feb 3, 2023
Merged

[ja] add docs for finalizers #38768

merged 1 commit into from
Feb 3, 2023

Conversation

FeLvi-zzz
Copy link
Member

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2023
@netlify
Copy link

netlify bot commented Jan 5, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d9c3999
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/63dc675d9133be000802069f
😎 Deploy Preview https://deploy-preview-38768--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@FeLvi-zzz FeLvi-zzz marked this pull request as ready for review January 5, 2023 03:21
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2023
t-inu
t-inu reviewed Jan 6, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, I reviewed only the glossary file.

content/ja/docs/reference/glossary/finalizer.md Outdated Show resolved Hide resolved
content/ja/docs/reference/glossary/finalizer.md Outdated Show resolved Hide resolved
content/ja/docs/reference/glossary/finalizer.md Outdated Show resolved Hide resolved
content/ja/docs/reference/glossary/finalizer.md Outdated Show resolved Hide resolved
content/ja/docs/reference/glossary/finalizer.md Outdated Show resolved Hide resolved
t-inu
t-inu reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed till the end.

content/ja/docs/concepts/overview/working-with-objects/finalizers.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/working-with-objects/finalizers.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/working-with-objects/finalizers.md Outdated Show resolved Hide resolved
content/ja/docs/concepts/overview/working-with-objects/finalizers.md Outdated Show resolved Hide resolved
@s-kawamura-w664 s-kawamura-w664 mentioned this pull request Jan 18, 2023
Merged
@FeLvi-zzz FeLvi-zzz requested review from t-inu and removed request for makocchi-git and kakts January 23, 2023 14:32
t-inu
t-inu approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 028239fa67640b990b0de73935f91d9aa807f4cd

@FeLvi-zzz
Copy link
Member Author

/assign @nasa9084
Please check them when you have the time.

@FeLvi-zzz FeLvi-zzz mentioned this pull request Jan 28, 2023
Merged
nasa9084
nasa9084 reviewed Feb 2, 2023
View reviewed changes
Copy link
Member

@nasa9084 nasa9084 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one nit comment

content/ja/docs/concepts/overview/working-with-objects/finalizers.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@nasa9084
Copy link
Member

nasa9084 commented Feb 3, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
t-inu
t-inu approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f8711cc83d6e01b5d4ba27e126e395fb47adb68

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084, t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7b84ea6 into kubernetes:main Feb 3, 2023
@FeLvi-zzz FeLvi-zzz deleted the issue-38641 branch February 3, 2023 12:26
@FeLvi-zzz FeLvi-zzz mentioned this pull request Feb 6, 2023
Closed
9 tasks
@s-kawamura-w664 s-kawamura-w664 mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-inu t-inu t-inu approved these changes

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@nasa9084 nasa9084

@t-inu t-inu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] Translate concepts/overview/working-with-objects/finalizers into Japanese
4 participants
@FeLvi-zzz @k8s-ci-robot @nasa9084 @t-inu