Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] Remove two pages of garbage collection #40150

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

s-kawamura-w664
Copy link
Contributor

Remove two pages of garbage collection from ja.
Target files:

  • content/ja/docs/concepts/cluster-administration/kubelet-garbage-collection.md
  • content/ja/docs/concepts/workloads/controllers/garbage-collection.md

These files was removed #28870 from en.
The description of garbage collection was moved other pages by that pr.

In ja, the updated files in #28870 is following status now.
I think the above two files can already be removed.

File name Update in #28870 Status in Ja
content/ja/docs/concepts/architecture/garbage-collection.md Newly added Added in #31063
content/ja/docs/concepts/cluster-administration/kubelet-garbage-collection.md Deleted Should delete
content/ja/docs/concepts/containers/images.md Modified Modified in #35809
content/ja/docs/concepts/overview/working-with-objects/finalizers.md Newly added Added in #38768
content/ja/docs/concepts/overview/working-with-objects/owners-dependents.md Newly added Added in #38794
content/ja/docs/concepts/workloads/controllers/garbage-collection.md Deleted Should delete
content/ja/docs/reference/glossary/finalizer.md Newly added Added in #38768
content/ja/docs/reference/glossary/garbage-collection.md Newly added Added in #39948 (Under review)
content/ja/docs/tasks/administer-cluster/use-cascading-deletion.md Newly added Added in #39960
static/_redirects Modify common

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2023
@k8s-ci-robot k8s-ci-robot requested a review from kakts March 20, 2023 07:38
@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Mar 20, 2023
@k8s-ci-robot k8s-ci-robot requested a review from t-inu March 20, 2023 07:38
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 20, 2023
@netlify
Copy link

netlify bot commented Mar 20, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a478d54
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64180d83f3539400088b6d8b
😎 Deploy Preview https://deploy-preview-40150--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nasa9084
Copy link
Member

Thank you for summarizing, great job!
/assign
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well summarized and easy to review!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a23a73160960580503025dbc8619cff1ed0ff44

@k8s-ci-robot k8s-ci-robot merged commit 768d6ae into kubernetes:main Mar 27, 2023
@s-kawamura-w664 s-kawamura-w664 deleted the remove_gc_pages branch April 21, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants