Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference/kubectl: Update docs for moving kubectl subresource to beta #39828

Merged
merged 1 commit into from Apr 7, 2023
Merged

reference/kubectl: Update docs for moving kubectl subresource to beta #39828

merged 1 commit into from Apr 7, 2023

Conversation

MadhavJivrajani
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/cli Categorizes an issue or PR as relevant to SIG CLI. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2023
@MadhavJivrajani MadhavJivrajani force-pushed the docs-update-kubectl-subresource branch from 491374f to e7a1b98 Compare March 7, 2023 04:55
@netlify
Copy link

netlify bot commented Mar 7, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 491374f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6406c3af863d220008e2fd71
😎 Deploy Preview https://deploy-preview-39828--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 7, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b8651be
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/642fd47b3977a80008b50073
😎 Deploy Preview https://deploy-preview-39828--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@soltysh soltysh mentioned this pull request Mar 14, 2023
Open
12 tasks
@mickeyboxell
Copy link
Contributor

mickeyboxell commented Apr 3, 2023 •
edited

@tengqm @sftim Would you mind taking a look at this when you have a moment? Since this is an update to kubectl, should it point to /main or /dev-12.7?
@MadhavJivrajani if this is ready for review, could you please remove [WIP] from the title?

@MadhavJivrajani MadhavJivrajani changed the title [WIP] reference/kubectl: Update docs for moving kubectl subresource to beta reference/kubectl: Update docs for moving kubectl subresource to beta Apr 5, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2023
@MadhavJivrajani
Copy link
Contributor Author

Done @mickeyboxell , thank you!

@mickeyboxell
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ea3bafdb3d4939c0ceabfa7d41cb48c30e3322c7

@MadhavJivrajani
reference/kubectl: Update docs for moving feaature to beta
b8651be 
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani MadhavJivrajani force-pushed the docs-update-kubectl-subresource branch from e7a1b98 to b8651be Compare April 7, 2023 08:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@MadhavJivrajani
Copy link
Contributor Author

@mickeyboxell @sftim PTAL, thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: eba3e318df0b6dbbed3650c9563f28c7f3a7b8d3

@mickeyboxell
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mickeyboxell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 182b8b3 into kubernetes:main Apr 7, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@nikhita nikhita Awaiting requested review from nikhita

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

Assignees

@mickeyboxell mickeyboxell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MadhavJivrajani @mickeyboxell @k8s-ci-robot @sftim