Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog for Efficient SELinux volume relabeling (Beta) #39836

Merged
merged 2 commits into from Apr 14, 2023
Merged

Add blog for Efficient SELinux volume relabeling (Beta) #39836

merged 2 commits into from Apr 14, 2023

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Mar 7, 2023 •
edited

This is a placeholder real PR.

I am not a writer, feel free to rephrase anything. I did not want to go in the detail too much, it's complicated enough already.

KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1710-selinux-relabeling
Feature: kubernetes/enhancements#1710

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2023
@jsafrane jsafrane changed the title [WIP] Add blog for Speed up recursive SELinux label change beta [WIP] Add blog for Efficient SELinux volume relabeling (Beta) Mar 7, 2023
@shatoboar shatoboar mentioned this pull request Mar 12, 2023
Open
16 tasks
@mickeyboxell
Copy link
Contributor

Hi @jsafrane, when you're ready, populate your placeholder PR with feature documentation and change the state of the PR from draft to ready for review. The official Docs deadline for PRs to be ready for review is tomorrow, March 21st. All docs PRs must be reviewed and ready to merge by April 4th. To mark a pull request as ready for review, navigate to the merge box and click Ready for review.

Regarding the content of your documentation, do your best to describe your feature and how to use it. If you need help structuring your documentation, ask in the #sig-docs Slack channel. For more information, please take a look at Documenting for a release to familiarize yourself with the documentation requirements for the release.

@jsafrane
Copy link
Member Author

I think that feature blog PRs need to be ready for review later, Tuesday 4th April 2023

@harshitasao
Copy link
Contributor

Hello, Comms Lead for the 1.27 release here. This feature blog is tracked for release, the deadline for submitting the draft is 4th of April- the sooner the better since there's still editing to be done afterwards. Any doubt, the Comms team is here to help.
Thank you!

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2023
@netlify
Copy link

netlify bot commented Mar 29, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 357e5a6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/643959f9b7dc54000742a75e
😎 Deploy Preview https://deploy-preview-39836--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@harshitasao
Copy link
Contributor

Hello @jsafrane, we're doing a global reminder about submitting a draft for review for all opted-in feature blogs. If it's at all possible, it is very helpful for the release team to have drafts submitted for review before the hard deadline date, to better plan the release dates and avoid missing out. Thank you!

@jsafrane jsafrane changed the title [WIP] Add blog for Efficient SELinux volume relabeling (Beta) Add blog for Efficient SELinux volume relabeling (Beta) Apr 4, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2023
@jsafrane jsafrane force-pushed the add-selinux-blog branch 4 times, most recently from e6c5546 to c9321b0 Compare April 4, 2023 11:44
sftim
sftim reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
pending assignment of a publication date

@jsafrane jsafrane force-pushed the add-selinux-blog branch 2 times, most recently from 67b18b0 to 5938551 Compare April 5, 2023 12:28
@harshitasao
Copy link
Contributor

harshitasao commented Apr 7, 2023 •
edited

Hello, Comms Lead for v1.27 here. The publication order and date for the Feature Blog series has been finalized and the tracking board is updated.

The publication date for this article is 18-04-2023 (April 18).

Thank you!

@jsafrane jsafrane force-pushed the add-selinux-blog branch 2 times, most recently from 83aff64 to 5fe3e75 Compare April 11, 2023 14:49
@jsafrane @RomanBednar
@dobsonj @sftim
Add blog for Speed up recursive SELinux label change beta
5b7e267 
Co-authored-by: Roman Bednář <rbednar@redhat.com>
Co-authored-by: Jonathan Dobson <dobsonj@gmail.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@sftim
Copy link
Contributor

sftim commented Apr 11, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023
@tengqm
Copy link
Contributor

tengqm commented Apr 12, 2023

/approve
Not sure if the date attribute in the frontmatter has to be a date-time string.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2023
@sftim sftim mentioned this pull request Apr 13, 2023
Merged
@sftim
Copy link
Contributor

sftim commented Apr 13, 2023

Not sure if the date attribute in the frontmatter has to be a date-time string.

I'd use an ISO 8601 date. Specifying a time of day is optional.

sftim
sftim reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

content/en/blog/_posts/2023-04-18-efficient-selinux-relabeling-beta.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 87e68a0d12a1ac5eb28ab2e42b4e7075bd8073ac

@jsafrane @sftim
Update content/en/blog/_posts/2023-04-18-efficient-selinux-relabeling…
357e5a6 
…-beta.md

Co-authored-by: Tim Bannister <tim@scalefactory.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 14, 2023 13:49
@sftim
Copy link
Contributor

sftim commented Apr 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 69b21225ad7e8fd5c706767f360badb32f60f227

@k8s-ci-robot k8s-ci-robot merged commit 49be5fd into kubernetes:main Apr 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobsonj dobsonj dobsonj left review comments

@RomanBednar RomanBednar RomanBednar left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jsafrane @mickeyboxell @harshitasao @sftim @tengqm @k8s-ci-robot @dobsonj @RomanBednar