Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add kubectl.kubernetes.io/default-logs-container deprecated information #39899

Merged
merged 1 commit into from Mar 10, 2023
Merged

add kubectl.kubernetes.io/default-logs-container deprecated information #39899

merged 1 commit into from Mar 10, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 10, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 10, 2023
@pacoxu pacoxu mentioned this pull request Mar 10, 2023
Closed
13 tasks
sftim
sftim reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I made suggestions; accepting those is optional.

content/en/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
content/en/docs/reference/labels-annotations-taints/_index.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 66d91d438c6950a26fdcd7bccd889f7f7d28184a

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 10, 2023 09:36
@netlify
Copy link

netlify bot commented Mar 10, 2023

✅ Pull request preview available for checking

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640af8d37701206f401cec7e
😎 Deploy Preview https://deploy-preview-39899--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 10, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 6ee6977
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640afa05648f520008308aa4
😎 Deploy Preview https://deploy-preview-39899--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@reylejano
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3afb91b57f7907e8e194a7904f178d0016b962e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 49f12c2 into kubernetes:main Mar 10, 2023
4 checks passed
@pacoxu pacoxu deleted the patch-14 branch June 26, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default container annotation that to be used by kubectl #2227
4 participants
@pacoxu @k8s-ci-robot @reylejano @sftim