Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HPA container resource metrics beta graduation #39929

Merged
merged 1 commit into from Apr 1, 2023
Merged

fix: HPA container resource metrics beta graduation #39929

merged 1 commit into from Apr 1, 2023

Conversation

sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Mar 12, 2023 •
edited

The document update for kubernetes/enhancements#1610

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2023
@sanposhiho sanposhiho mentioned this pull request Mar 12, 2023
Closed
@netlify
Copy link

netlify bot commented Mar 12, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ba9baa3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/640d57c10af0800009da7393
😎 Deploy Preview https://deploy-preview-39929--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@gjtempleton gjtempleton mentioned this pull request Mar 13, 2023
Closed
@sanposhiho sanposhiho changed the base branch from main to dev-1.27 March 13, 2023 22:47
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 21, 2023
@sanposhiho sanposhiho force-pushed the graduate-beta-container-resourcemetric branch from 3381dea to 3a4f7ab Compare March 21, 2023 06:25
@sanposhiho sanposhiho marked this pull request as ready for review March 21, 2023 06:25
@sanposhiho
Copy link
Member Author

/hold cancel

@sanposhiho sanposhiho changed the title WIP: HPA container resource metrics graduation fix: HPA container resource metrics beta graduation Mar 21, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2023
@gjtempleton
Copy link
Member

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 056c84dbf09d53924f4e02a597af76ae6a3111c2

@sanposhiho
Copy link
Member Author

/assign @krol3

For approval

@tengqm
Copy link
Contributor

tengqm commented Apr 1, 2023

Thanks.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9d05239 into kubernetes:dev-1.27 Apr 1, 2023
1 check passed
@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@sftim sftim Awaiting requested review from sftim

Assignees

@tengqm tengqm

@gjtempleton gjtempleton

@krol3 krol3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sanposhiho @gjtempleton @k8s-ci-robot @tengqm @krol3