Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates for dockershim removal #40192

Merged
merged 2 commits into from
Mar 24, 2023
Merged

updates for dockershim removal #40192

merged 2 commits into from
Mar 24, 2023
+68 −8

Conversation

SergeyKanzhelev
Copy link
Member

/sig node
/kind clenaup

Fixes #30842
Fixes #30681

Also fixes some versioning problems.

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: The label(s) kind/clenaup cannot be applied, because the repository doesn't have them.

In response to this:

/sig node
/kind clenaup

Fixes #30842
Fixes #30681

Also fixes some versioning problems.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2023
@netlify
Copy link

netlify bot commented Mar 21, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9b78ecf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/641c9795607b4e00099ecfc8
😎 Deploy Preview https://deploy-preview-40192--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tengqm
tengqm reviewed Mar 22, 2023
View reviewed changes
content/en/blog/_posts/2022-11-28-registry-k8s-io-change.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-11-28-registry-k8s-io-change.md Outdated Show resolved Hide resolved
content/en/docs/setup/production-environment/container-runtimes.md Outdated Show resolved Hide resolved
content/en/docs/setup/production-environment/container-runtimes.md Outdated Show resolved Hide resolved
content/en/docs/setup/production-environment/container-runtimes.md Outdated Show resolved Hide resolved
...asks/administer-cluster/migrating-from-dockershim/check-if-dockershim-removal-affects-you.md Outdated Show resolved Hide resolved
...asks/administer-cluster/migrating-from-dockershim/check-if-dockershim-removal-affects-you.md Outdated Show resolved Hide resolved
...asks/administer-cluster/migrating-from-dockershim/check-if-dockershim-removal-affects-you.md Outdated Show resolved Hide resolved
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Mar 23, 2023
Open
@SergeyKanzhelev @tengqm
Apply suggestions from code review
9b78ecf 
Co-authored-by: Qiming Teng <tengqm@outlook.com>
@SergeyKanzhelev
Copy link
Member Author

/assign @qiutongs

for tech review

@tengqm
Copy link
Contributor

tengqm commented Mar 24, 2023

/approve

@tengqm
Copy link
Contributor

tengqm commented Mar 24, 2023

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiutongs, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b07cf384ed898854c3b03b945b7aa9da0fb34640

@k8s-ci-robot k8s-ci-robot merged commit a5ec218 into kubernetes:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@qiutongs qiutongs qiutongs approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

Assignees

@tengqm tengqm

@qiutongs qiutongs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node PR Triage
Archived in project
Milestone
No milestone
4 participants
@SergeyKanzhelev @k8s-ci-robot @tengqm @qiutongs