Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links between Securing a Cluster and Security Checklist for alignment #40915

Merged

Conversation

mrgiles
Copy link
Contributor

@mrgiles mrgiles commented May 1, 2023

Link documents Securing a Cluster (task) with Security Checklist (concept) for alignment. Fixes #37738

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2023
@k8s-ci-robot k8s-ci-robot requested review from enj and kbhawkey May 1, 2023 05:26
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2023
@mrgiles
Copy link
Contributor Author

mrgiles commented May 1, 2023

FYI @sftim

@Ritikaa96
Copy link
Contributor

Hi @mrgiles Please note that the issue was mainly to align both pages advice for secure cluster. Refer to :

We should ensure that the advice in the two documents is aligned, and also make sure that the two documents link to each other.

Why is this needed
It's a bad idea to document multiple ways to make sure that your cluster is secure, unless those are well aligned.

I have not matched the pages but just wanted to add this as a reminder. Thanks for the contribution.

@Ritikaa96
Copy link
Contributor

Also please check the reason for the checks being unsuccessful

@mrgiles mrgiles force-pushed the 37738_securing_cluster_checklist_align branch from c11b387 to 19a3dc0 Compare May 1, 2023 06:29
@netlify
Copy link

netlify bot commented May 1, 2023

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 19a3dc0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/644f5c4ce94c1500078c8201
😎 Deploy Preview https://deploy-preview-40915--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mrgiles
Copy link
Contributor Author

mrgiles commented May 1, 2023

Thanks @Ritikaa96, I just saw this note: #25119 (comment).
Where can I find this Hardening Guide @raesene?
What do you think @sftim, is it worth keeping the Securing a Cluster doc?

@sftim
Copy link
Contributor

sftim commented May 2, 2023

What do you think @sftim, is it worth keeping the Securing a Cluster doc?

It is, at least for now.

@raesene
Copy link
Contributor

raesene commented May 3, 2023

@mrgiles the hardening guide is still in development, definitely not one to link to at the moment :)

@mrgiles
Copy link
Contributor Author

mrgiles commented May 14, 2023

@sftim @tengqm, @Ritikaa96 , I'm afraid I need a little extra guidance to continue working on this issue. I'd like to know if you have a suggestion on how I should proceed to solve the problem. I'm really new to this so that's why I'm requesting a little extra help here. Thanks!

@tengqm
Copy link
Contributor

tengqm commented May 14, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2023
@mrgiles
Copy link
Contributor Author

mrgiles commented May 14, 2023

Hi @tengqm, thank you for your review. If you think that the changes satisfy the requirements in #37738, could you also add an lgtm label for the PR to proceed? Thanks!

@mrgiles
Copy link
Contributor Author

mrgiles commented May 15, 2023

/assign @tengqm

@mrgiles
Copy link
Contributor Author

mrgiles commented May 15, 2023

@tengqm please disregard the adding the lgtm label comment. Thanks!

@mrgiles
Copy link
Contributor Author

mrgiles commented May 15, 2023

/assign @sftim

@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 32a260cb5294ff47e6fa56798c5976e8a8ca6f78

@k8s-ci-robot k8s-ci-robot merged commit 821ca22 into kubernetes:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align securing a cluster task with security checklist
7 participants