Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[id] Update kustomize examples to use non-deprecated resources key #41572

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[id] Update kustomize examples to use non-deprecated resources key #41572

merged 1 commit into from
Jun 26, 2023

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Jun 9, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language labels Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 9, 2023
@netlify
Copy link

netlify bot commented Jun 9, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 464d097
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6483aa1426954f0008115003
😎 Deploy Preview https://deploy-preview-41572--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

dipesh-rawat
dipesh-rawat reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made here in sync with 'en' PR.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 750df8f6ed8175212c78aa8c08a23cc90423c024

@Arhell
Copy link
Member Author

Arhell commented Jun 25, 2023

cc @habibrosyad

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: habibrosyad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@habibrosyad
Copy link
Member

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 802aa3b into kubernetes:main Jun 26, 2023
4 checks passed
@Arhell Arhell deleted the id-update branch June 26, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@habibrosyad habibrosyad habibrosyad approved these changes

@ariscahyadi ariscahyadi Awaiting requested review from ariscahyadi

Assignees

@habibrosyad habibrosyad

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Arhell @k8s-ci-robot @habibrosyad @dipesh-rawat