Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: fix release state for podresources API #41804

Merged
merged 1 commit into from Jul 3, 2023

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Jun 29, 2023

followup to #41506 (review)
we fix the release state of the podresources API (related to device monitoring)

KEP: kubernetes/enhancements#606
enhancement: kubernetes/enhancements#3743

Mark the API, needed to monitor the device plugins, as stable

Signed-off-by: Francesco Romani <fromani@redhat.com>
@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jun 29, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 29, 2023
@ffromani ffromani changed the title fix release state for podresources API node: fix release state for podresources API Jun 29, 2023
@Shubham82
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 30, 2023
@ffromani
Copy link
Contributor Author

/cc @SergeyKanzhelev @swatisehgal
for sig-node

@Shubham82
Copy link
Contributor

Thanks, @ffromani
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c191d71c11991bae6d8cdcf07c5f7542f239fbf4

@ffromani
Copy link
Contributor Author

ffromani commented Jul 3, 2023

this is the final piece to finalize kubernetes/enhancements#3743 which was mostly (but not completely) merged during the 1.27 cycle, slipped back to 1.28 and whose missing changes got merged at the very beginning of the 1.28 cycle.

Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from node perspective

@ffromani
Copy link
Contributor Author

ffromani commented Jul 3, 2023

/assign @annajung

(per bot suggestion)

@tengqm
Copy link
Contributor

tengqm commented Jul 3, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: swatisehgal, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit a4a0872 into kubernetes:dev-1.28 Jul 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants