Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create-external-load-balancer.md #41926

Closed
wants to merge 1 commit into from
Closed

Update create-external-load-balancer.md #41926

wants to merge 1 commit into from

Conversation

cezarygerard
Copy link

describe Health check node port response

add info about new response header in 1.28
kubernetes/kubernetes#118999

This was discussed on SIG Network on 6th July 2023

@cezarygerard
Update create-external-load-balancer.md
bb99ca9 
describe Healcth check node port response

add info about new response header  in 1.28 kubernetes/kubernetes#118999

This was discussed on SIG Network on 6th July 2023
@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign annajung for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2023
@cezarygerard cezarygerard mentioned this pull request Jul 7, 2023
Merged
@aojea
Copy link
Member

aojea commented Jul 7, 2023

/assign @thockin @danwinship @sftim

depends on kubernetes/kubernetes#118999

danwinship
danwinship reviewed Jul 7, 2023
View reviewed changes
content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md
Comment on lines 159 to +161
### Caveats and limitations when preserving source IPs

Health check node port serves HTTP traffic. The response body contains JSON service name, namespace and number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't belong under that heading.

I'm not sure it really belongs in this document at all though; this is information that LoadBalancer implementations need to know. It's not really useful to end users of Kubernetes...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim we want to add this information about the healthceck Nodeport used for Services with type LoadBalancer when externalTrafficPolicy is set to Local , so implementations can now the nodes with pods and how many pods are running on the node. Since you were restructuring this documentation recently, can you help us to identify the best place to add it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update https://kubernetes.io/docs/reference/networking/virtual-ips/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps, you can frame it as a note along the lines of “Older Kubernetes releases had a shortcoming where …”

@Rishit-dagli
Copy link
Member

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.28 milestone Aug 12, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 10, 2023

/close
This thing missed 1.28.
Please consider reopen it against dev-1.29 if appropriate.

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

/close
This thing missed 1.28.
Please consider reopen it against dev-1.29 if appropriate.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@aojea aojea aojea left review comments

@sftim sftim sftim left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@danwinship danwinship

@thockin thockin

@sftim sftim

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cezarygerard @k8s-ci-robot @aojea @Rishit-dagli @tengqm @danwinship @sftim @thockin