Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create-external-load-balancer.md #41926

Closed
wants to merge 1 commit into from
Closed

Update create-external-load-balancer.md #41926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 15 additions & 0 deletions content/en/docs/tasks/access-application-cluster/create-external-load-balancer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,21 @@ spec:

### Caveats and limitations when preserving source IPs

Health check node port serves HTTP traffic. The response body contains JSON service name, namespace and number
Comment on lines 159 to +161
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't belong under that heading.

I'm not sure it really belongs in this document at all though; this is information that LoadBalancer implementations need to know. It's not really useful to end users of Kubernetes...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim we want to add this information about the healthceck Nodeport used for Services with type LoadBalancer when externalTrafficPolicy is set to Local , so implementations can now the nodes with pods and how many pods are running on the node. Since you were restructuring this documentation recently, can you help us to identify the best place to add it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update https://kubernetes.io/docs/reference/networking/virtual-ips/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps, you can frame it as a note along the lines of “Older Kubernetes releases had a shortcoming where …”

of local endpoints:

```json
{
"service": {
"namespace": "default",
"name": "example-service"
},
"localEndpoints": 2
}
```

Starting from kubernetes v1.28 number of local endpoints is returned also in response header `X-Load-Balancing-Endpoint-Weight`.

Load balancing services from some cloud providers do not let you configure different weights for each target.

With each target weighted equally in terms of sending traffic to Nodes, external
Expand Down