Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document dynamic cardinality enforcement (KEP 2305) #41998

Merged
merged 1 commit into from Nov 28, 2023
Merged

Document dynamic cardinality enforcement (KEP 2305) #41998

merged 1 commit into from Nov 28, 2023

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Jul 12, 2023

document kep-2305: metric cardinality enforcement

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 12, 2023
@rexagod rexagod mentioned this pull request Jul 12, 2023
Open
8 tasks
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2023
@rexagod rexagod changed the base branch from main to dev-1.28 July 12, 2023 15:37
@rexagod rexagod changed the base branch from dev-1.28 to main July 12, 2023 15:38
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@rexagod rexagod changed the base branch from main to dev-1.28 July 12, 2023 15:40
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2023
@netlify
Copy link

netlify bot commented Jul 12, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d7963f7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64aec8a31c51680008434dad
😎 Deploy Preview https://deploy-preview-41998--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 12, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 02378c3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64aec9563200910008118df9
😎 Deploy Preview https://deploy-preview-41998--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Jul 12, 2023

Linked to kubernetes/enhancements#2305

@katcosgrove
Copy link
Contributor

Hello @rexagod 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 25th July 2023. Thank you!

@rexagod
Copy link
Member Author

rexagod commented Jul 24, 2023

Hello, @katcosgrove. The linked k/k PR is no longer tracked and has been moved out of the milestone. I’m assuming this will have to be deferred till the next release?

@katcosgrove
Copy link
Contributor

Ah okay! Updating our tracking sheet, thank you!

@rexagod rexagod changed the base branch from dev-1.28 to dev-1.29 October 10, 2023 12:00
@rexagod
Copy link
Member Author

rexagod commented Oct 10, 2023

Changed base to target latest.

@Princesso
Copy link
Contributor

Hello @rexagod 👋, I cannot see any file changes on this PR. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@Princesso
Copy link
Contributor

Princesso commented Nov 3, 2023 •
edited

Hello @rexagod @logicalhan 👋, gentle reminder to take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 14th November 2023. Thank you!

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 90c282e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6565ad4ec692d5000822819f

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2023
@sftim
Copy link
Contributor

sftim commented Nov 26, 2023

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2023
@rexagod
Copy link
Member Author

rexagod commented Nov 26, 2023 •
edited

@sftim Do I need Han's LGTM here again for this to be merged (after all reviews are addressed)? US folks are out due to Thanksgiving, so that might not be possible within the limited time-frame.

@katcosgrove
Copy link
Contributor

Hi @rexagod! I'm the Docs lead for v1.29. You will need an LGTM from someone, yes. If @logicalhan is still out after Thanksgiving, someone from your SIG's leadership will suffice. Would you like me to find someone for you?

logicalhan
logicalhan reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@sftim
Copy link
Contributor

sftim commented Nov 27, 2023

Thanks but we really do need these docs revised in line with the reviews so far.

/hold
/lgtm cancel

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 27, 2023
@rexagod
kep-2305: document dynamic cardinality enforcement
90c282e 
Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2023
sftim
sftim reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 75be3702ee6815340fa272c357bf7fbef5ee21ae

@sftim
Copy link
Contributor

sftim commented Nov 28, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2023
@sftim sftim dismissed their stale review November 28, 2023 10:23

Superseded

@k8s-ci-robot k8s-ci-robot merged commit d608006 into kubernetes:dev-1.29 Nov 28, 2023
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.29 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@natalisucks natalisucks Awaiting requested review from natalisucks

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@tengqm tengqm Awaiting requested review from tengqm

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@logicalhan logicalhan

@kbhawkey kbhawkey

@tengqm tengqm

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.29
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rexagod @sftim @katcosgrove @Princesso @k8s-ci-robot @logicalhan @kbhawkey @tengqm