Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upgrade guides to clarify that legacy repos are frozen #43472

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Update upgrade guides to clarify that legacy repos are frozen #43472

merged 3 commits into from
Oct 17, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 13, 2023

This PR updates relevant upgrade guides to clarify that legacy repos are frozen and that you need to switch to the new Kubernetes repositories to installs versions released after September 13, 2023.

/assign @sftim @tengqm @Affan-7 @saschagrunert @cpanato
cc @kubernetes/release-engineering

@k8s-ci-robot
Copy link
Contributor

@xmudrii: GitHub didn't allow me to assign the following users: Affan-7.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This PR updates relevant upgrade guides to clarify that legacy repos are frozen and that you need to switch to the new Kubernetes repositories to installs versions released after September 13, 2023.

/assign @sftim @tengqm @Affan-7 @saschagrunert @cpanato
cc @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 13, 2023
@netlify
Copy link

netlify bot commented Oct 13, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f02af59
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652907982f6ac800085e8413
😎 Deploy Preview https://deploy-preview-43472--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 13, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit d0d271d
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652d5c545d348200083045a7
😎 Deploy Preview https://deploy-preview-43472--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Oct 13, 2023

How to squash this:

  • 1 commit adding the shortcode and its localization string
  • a second commit that uses the new shortcode

We should refactor this further IMO to make a reusable-note shortcode. However, that'd be best done after this merges.

@xmudrii
Copy link
Member Author

xmudrii commented Oct 13, 2023

@sftim Done, the PR is squashed and ready for review

sftim
sftim reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Overall a benefit to merge this

data/i18n/en/en.toml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f4cfcc5c8400c925b2450806a561f628a4c43df

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2023
Affan-7
Affan-7 reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@Affan-7 Affan-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tengqm
tengqm reviewed Oct 15, 2023
View reviewed changes
data/i18n/en/en.toml Outdated Show resolved Hide resolved
@xmudrii
Add legacy-repos-deprecation shortcode and localization
5fc6cfa 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update install/upgrade guides to clarify that legacy repos are frozen
8a587ac 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Oct 16, 2023

@tengqm @Affan-7 Fixed all comments, PTAL :)

saschagrunert
saschagrunert reviewed Oct 16, 2023
View reviewed changes
data/i18n/en/en.toml Outdated Show resolved Hide resolved
@xmudrii
Update the legacy repos message
d0d271d 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@tengqm
Copy link
Contributor

tengqm commented Oct 16, 2023

Thanks.
/label tide/merge-method-squash
/approve

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@windsonsea
Copy link
Member

Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45e7a94adf654af3a0b2d7dd9bbc353fdf1d8db3

@k8s-ci-robot k8s-ci-robot merged commit e4a2ab2 into kubernetes:main Oct 17, 2023
6 checks passed
@xmudrii xmudrii deleted the clarify-pkgs branch October 17, 2023 08:13
This was referenced Oct 17, 2023
Merged
Merged
Merged
Merged
koreanddinghwan pushed a commit to koreanddinghwan/website that referenced this pull request Jan 28, 2024
@xmudrii @koreanddinghwan
Update upgrade guides to clarify that legacy repos are frozen (kubern…
6c93008 
…etes#43472)

* Add legacy-repos-deprecation shortcode and localization

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>

* Update install/upgrade guides to clarify that legacy repos are frozen

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>

* Update the legacy repos message

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>

---------

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@onlydole onlydole Awaiting requested review from onlydole

@cpanato cpanato Awaiting requested review from cpanato

@sftim sftim Awaiting requested review from sftim

@tengqm tengqm Awaiting requested review from tengqm

@Affan-7 Affan-7 Awaiting requested review from Affan-7

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

@tengqm tengqm

@sftim sftim

@windsonsea windsonsea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xmudrii @k8s-ci-robot @sftim @tengqm @windsonsea @saschagrunert @Affan-7 @cpanato