Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugepages: add some details on allocation #43537

Merged
merged 2 commits into from
Oct 24, 2023
Merged

hugepages: add some details on allocation #43537

merged 2 commits into from
Oct 24, 2023

Conversation

profnandaa
Copy link
Contributor

This commit add a little more details on pre-allocation and dynamic allocation of huge pages on the node.

It also links to the Linux documentation for further details but gives a quick example on multiple page sizes that is not very obvious from the Linux documentation currently.

/cc. @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Pull request preview available for checking

Name Link
🔨 Latest commit ca2b302
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/652f69ddb17e5800092eade5
😎 Deploy Preview https://deploy-preview-43537--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@derekwaynecarr
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e8cc2f19f86c1795cbc908bbd5d41b6469ca25f8

windsonsea
windsonsea reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to find what you have changed. Is anything wrong when you are editing this page?

@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

This PR changed the EOL character?

derekwaynecarr
derekwaynecarr reviewed Oct 18, 2023
View reviewed changes
content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md Outdated
and `512*2 MiB` of 2 MiB pages:

```
GRUB_CMDLINE_LINUX="hugepagesz=1G hugepages=2 hugepagesz=2M hugepages=512"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the primary technical change. I do not know why the edit appears larger.

@profnandaa
Copy link
Contributor Author

It's hard to find what you have changed. Is anything wrong when you are editing this page?

Sorry, this was oversight on my end, failed to check my diff. This is caused by my Windows environment CRLF settings, fixing that rn.

@profnandaa
hugepages: add some details on allocation
9803cdc 
This commit add a little more details on pre-allocation
and dynamic allocation of huge pages on the node.

It also links to the Linux documentation for further
details but gives a quick example on multiple page sizes
that is not very obvious from the Linux documentation
currently.

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2023
@tengqm
Copy link
Contributor

tengqm commented Oct 18, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ef8492aeea56d720a5cf70b0bb2c9a02d1d472e

@anjum-edge
Copy link

LGTM is having bugs due to this it is showing errors
lookout for the new features and bugs

@profnandaa profnandaa mentioned this pull request Oct 19, 2023
Closed
@sftim
Copy link
Contributor

sftim commented Oct 24, 2023

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 24, 2023
@sftim
Copy link
Contributor

sftim commented Oct 24, 2023

LGTM is having bugs due to this it is showing errors lookout for the new features and bugs

I'm not sure I understand - is this nonsense?

sftim
sftim reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md

{{< note >}}
For dynamically allocated pages (after boot), the Kubelet needs to be restarted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For dynamically allocated pages (after boot), the Kubelet needs to be restarted
For dynamically allocated pages (after boot), the kubelet needs to be restarted

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 189cdb3 into kubernetes:main Oct 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@windsonsea windsonsea windsonsea left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@tengqm tengqm

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@profnandaa @derekwaynecarr @k8s-ci-robot @tengqm @anjum-edge @sftim @windsonsea