Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating broken links #43659

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Updating broken links #43659

merged 1 commit into from
Oct 24, 2023

Conversation

SaranBalaji90
Copy link
Contributor

@SaranBalaji90 SaranBalaji90 commented Oct 23, 2023 •
edited

Updating broken links for content/id/docs/concepts/cluster-administration/networking.md and content/id/docs/concepts/cluster-administration/addons.md

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language labels Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2023
@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fe43dc8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65377e716885690008ddc691
😎 Deploy Preview https://deploy-preview-43659--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the language/ja Issues or PRs related to Japanese language label Oct 23, 2023
dipesh-rawat
dipesh-rawat reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaranBalaji90 Thanks for your contribution. It seems this PR modifies files in different languages (Indonesian and Japanese). However, the documentation process differs for each localization, and we usually don't accept PRs that affect multiple languages at once. I suggest only changing content for one language and submitting a separate PR for each language. I hope this suggestion is helpful.

@dipesh-rawat
Copy link
Member

/hold
Hold till the PR addresses changes only related to a single language.
(OK to unhold once that's corrected)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
@SaranBalaji90
Copy link
Contributor Author

@dipesh-rawat Thank you for taking a look and guiding me with the process. I will update the PR accordingly.

@SaranBalaji90 SaranBalaji90 reopened this Oct 24, 2023
@SaranBalaji90 SaranBalaji90 mentioned this pull request Oct 24, 2023
Merged
@dipesh-rawat
Copy link
Member

/remove-language ja

@k8s-ci-robot k8s-ci-robot removed the language/ja Issues or PRs related to Japanese language label Oct 24, 2023
@dipesh-rawat
Copy link
Member

/unhold
PR now targets single language

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
habibrosyad
habibrosyad approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@habibrosyad habibrosyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6437abb6dbbee163d6800593abc4567965c0c496

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: habibrosyad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit c98a5e1 into kubernetes:main Oct 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@habibrosyad habibrosyad habibrosyad approved these changes

@danninov danninov Awaiting requested review from danninov

Assignees

@habibrosyad habibrosyad

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SaranBalaji90 @dipesh-rawat @k8s-ci-robot @habibrosyad