Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update broken github link for Japanese Storage-limit doc. #43670

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Update broken github link for Japanese Storage-limit doc. #43670

merged 1 commit into from
Nov 21, 2023

Conversation

SaranBalaji90
Copy link
Contributor

@SaranBalaji90 SaranBalaji90 commented Oct 24, 2023 •
edited
Loading

Updates broken github link for Japanese doc in content/ja/docs/concepts/storage/storage-limits.md. This is follow up PR from - #43659

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a47b222
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65377f787f34940007336669
😎 Deploy Preview https://deploy-preview-43670--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

aj11anuj
aj11anuj approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@aj11anuj aj11anuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍

t-inu
t-inu reviewed Nov 4, 2023
View reviewed changes
Copy link
Member

@t-inu t-inu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6e9995dcce50f922e83b464131401846b7614dce

@t-inu
Copy link
Member

t-inu commented Nov 4, 2023

/assign @nasa9084

kakts
kakts approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@kakts kakts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nasa9084
Copy link
Member

Thank you!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aj11anuj, kakts, nasa9084

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit da69302 into kubernetes:main Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-inu t-inu t-inu left review comments

@kakts kakts kakts approved these changes

@aj11anuj aj11anuj aj11anuj approved these changes

@ptux ptux Awaiting requested review from ptux

Assignees

@nasa9084 nasa9084

@t-inu t-inu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SaranBalaji90 @k8s-ci-robot @t-inu @nasa9084 @kakts @aj11anuj