New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.29 - Add a blog post about VolumeAttributesClass #43777
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
36ff05b
to
04b37a5
Compare
1a56e89
to
69d1c46
Compare
Hi @sunnylovestiramisu! , Here the communications 1.29 Team, the deadline to the feature blog be ready to review is this Friday, Nov 17th, the proposal publish date will be Dec 15th. cc: @a-mccarthy @kcmartin @James-Quigley |
@krol3 We's like to post the blog post in mid Dec ish probably around Dec 15th? What do you think? |
Scheduled it! Thanks @sunnylovestiramisu 🙏🏾 |
@sunnylovestiramisu 1.29 Comms Team here! The blog format requires that you add the following to the beginning of the file:
|
@@ -0,0 +1,162 @@ | |||
# Kubernetes v1.29: VolumeAttributesClass for Volume Modification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment about the correct formatting for the blog post
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated base on comments: 3367a87
|
||
**Authors**: Sunny Song(Google) | ||
|
||
The v1.29 release of Kubernetes introduced an alpha feature to support modify volume by changing VolumeAttributesClass that was assigned to a PersistentVolumeClaim (PVC). With the feature enabled, Kubernetes can handle updates of volume attributes other than capacity. Allowing volume attributes to be changed without managing it through different provider's APIs directly simplifies the current flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v1.29 release of Kubernetes introduced an alpha feature to support modify volume by changing VolumeAttributesClass that was assigned to a PersistentVolumeClaim (PVC). With the feature enabled, Kubernetes can handle updates of volume attributes other than capacity. Allowing volume attributes to be changed without managing it through different provider's APIs directly simplifies the current flow. | |
The v1.29 release of Kubernetes introduced an alpha feature to support modify volume | |
by changing VolumeAttributesClass that was assigned to a PersistentVolumeClaim (PVC). | |
With the feature enabled, Kubernetes can handle updates of volume attributes other than capacity. | |
Allowing volume attributes to be changed without managing it through different | |
provider's APIs directly simplifies the current flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in: 3367a87
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by changing VolumeAttributesClass that was assigned to a PersistentVolumeClaim (PVC).
It maybe misunderstand by users how to change the volume attributes of a PVC. It should be changed the reference of the PVC's volume attributes class by editing the PVC's spec.volumeAttributesClassName field, not the VolumeAttributesClass itself.
content/en/blog/_posts/2023-11-20-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-11-20-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-11-20-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-11-20-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
|
||
* See the [VolumeAttributesClass KEP](https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3751-volume-attributes-class) for more information on the design | ||
* You can view or comment on the [project board](https://github.com/orgs/kubernetes-csi/projects/72) for VolumeAttributesClass | ||
* In order to move this feature towards beta, we need feedback from the community, so here's a call to action: add support to the CSI drivers, try out this feature, consider how it can help with problems that your users are having… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* In order to move this feature towards beta, we need feedback from the community, so here's a call to action: add support to the CSI drivers, try out this feature, consider how it can help with problems that your users are having… | |
* In order to move this feature towards beta, we need feedback from the community, | |
so here's a call to action: add support to the CSI drivers, try out this feature, | |
consider how it can help with problems that your users are having… |
|
||
## How to use it | ||
|
||
If you want to test the feature whilst it's alpha, you need to enable the relevant feature gate in the kube-controller-manager and the kube-apiserver. Use the --feature-gates command line argument: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to test the feature whilst it's alpha, you need to enable the relevant feature gate in the kube-controller-manager and the kube-apiserver. Use the --feature-gates command line argument: | |
If you want to test the feature whilst it's alpha, you need to enable the relevant feature gate | |
in the kube-controller-manager and the kube-apiserver. Use the --feature-gates command line argument: |
Do we have some more formal docs under /content/en/docs for this VolumeAttributesClass thing? |
Docs PR in: #43463 |
69d1c46
to
3367a87
Compare
|
||
## VolumeAttributesClass | ||
|
||
The new resource.k8s.io/v1alpha1 API group provides two new types: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource.k8s.io/v1alpha1
is not correct.
VolumeAttributesClass API belongs to storage.k8s.io/v1alpha1
.
PVC belongs to core/v1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nits
``` | ||
|
||
|
||
It also requires the CSI driver has implemented the ModifyVolume API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also requires the CSI driver has implemented the ModifyVolume API. | |
It also requires that the CSI driver has implemented the ModifyVolume API. |
|
||
### User Flow | ||
|
||
If you would like to see the feature in action and verify it works fine in your cluster here's what you can try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you would like to see the feature in action and verify it works fine in your cluster here's what you can try: | |
If you would like to see the feature in action and verify it works fine in your cluster, here's what you can try: |
|
||
## Getting involved | ||
|
||
We always welcome new contributors so if you would like to get involved you can join our [Kubernetes Storage Special-Interest-Group](https://github.com/kubernetes/community/tree/master/sig-storage) (SIG). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always welcome new contributors so if you would like to get involved you can join our [Kubernetes Storage Special-Interest-Group](https://github.com/kubernetes/community/tree/master/sig-storage) (SIG). | |
We always welcome new contributors. So, if you would like to get involved, you can join our [Kubernetes Storage Special-Interest-Group](https://github.com/kubernetes/community/tree/master/sig-storage) (SIG). |
content/en/blog/_posts/2023-11-20-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
provider's APIs directly simplifies the current flow. | ||
|
||
You can read VolumeAttributesClass in the Kubernetes documentation for more details | ||
about how to use that, or you can read on to learn about why the Kubernetes project is supporting this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about how to use that, or you can read on to learn about why the Kubernetes project is supporting this feature. | |
or you can read on to learn about why the Kubernetes project is supporting this feature. |
@sftim Changed date to Dec 15th. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I recommend some whitespace changes.
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
```yaml | ||
kubectl describe pvc <PVC_NAME> | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please indent all of the non-blank lines by three spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a command, it should not be yaml actually. Let me correct that.
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
f6f491d
to
255d8b0
Compare
@sftim updated the PR again. |
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
255d8b0
to
fbcae05
Compare
content/en/blog/_posts/2023-12-15-volume-attributes-class/index.md
Outdated
Show resolved
Hide resolved
fbcae05
to
0daa5df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Markdown looks right. Thanks for putting the time in on this article @sunnylovestiramisu.
/lgtm
LGTM label has been added. Git tree hash: 60cbd2a3828875173b82d5e24127a0e1c0484820
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label tide/merge-method-squash We can remove that label (tide/merge-method-squash) once this is only 1 commit. It's also OK to merge this PR just as it is. 🛑 Do not merge until Kubernetes v1.29 is released 🛑 |
/remove-label tide/merge-method-squash /hold cancel |
Add a blog for kubernetes/enhancements#3751 (
WIP)Draft of the blog post: https://docs.google.com/document/d/1IDtALLef8mh9PLNj545hdZgBTyWHql9l0zduSV_yGSg/edit?resourcekey=0-PLJOfJNET_34xAdlGwLXiQ#heading=h.ymhtacwivbvt