New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise body of patch request in StatefulSet tutorial #44730
Conversation
…rials/stateful-application/basic-stateful-set/#on-delete
Welcome @PrashantDesale2004! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @PrashantDesale2004, sign EasyCLA first, it will help reviewers to review and approve your PR. You can find details here - Sign here - |
Also ,
Update your current PR, with respect to the given message here, choose a commit message which doesn't contain -
Write clear commit message, so that it can be short and understable, u can look at this article for your next commit messages also look at this piece of content which will help you on your next PR. Thanks for raising the PR for the issue #44713. |
Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request. You can edit the title by writing /retitle in a comment.
When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
will i have to raise PR again ? |
/retitle Revise body of patch request in StatefulSet tutorial |
No. You can edit what you have sent in. However, if you are not sure how to edit an existing commit and would prefer to open a new pull request, you could do that instead. |
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
fixed #44713
from
kubectl patch statefulset web -p '{"spec":{"updateStrategy":{"type":"OnDelete"}}}'
to
kubectl patch statefulset web -p '{"spec":{"updateStrategy":{"type":"OnDelete","rollingUpdate":null}}}'