Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise body of patch request in StatefulSet tutorial #44730

Closed
wants to merge 2 commits into from

Conversation

PrashantDesale2004
Copy link
Contributor

@PrashantDesale2004 PrashantDesale2004 commented Jan 13, 2024

fixed #44713
from
kubectl patch statefulset web -p '{"spec":{"updateStrategy":{"type":"OnDelete"}}}'

to
kubectl patch statefulset web -p '{"spec":{"updateStrategy":{"type":"OnDelete","rollingUpdate":null}}}'

…rials/stateful-application/basic-stateful-set/#on-delete
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 13, 2024
Copy link

linux-foundation-easycla bot commented Jan 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @PrashantDesale2004!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jan 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign natalisucks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 13, 2024
Copy link

netlify bot commented Jan 13, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2140c49
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65a4dcbc4281500008e04c1d
😎 Deploy Preview https://deploy-preview-44730--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@utkarsh-singh1
Copy link
Contributor

Also ,

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Update your current PR, with respect to the given message here, choose a commit message which doesn't contain -

  • Issue no. or its description
  • Do not use any hastag

Write clear commit message, so that it can be short and understable, u can look at this article for your next commit messages also look at this piece of content which will help you on your next PR.

Thanks for raising the PR for the issue #44713.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 14, 2024
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PrashantDesale2004
Copy link
Contributor Author

Also ,

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:

Update your current PR, with respect to the given message here, choose a commit message which doesn't contain -

  • Issue no. or its description
  • Do not use any hastag

Write clear commit message, so that it can be short and understable, u can look at this article for your next commit messages also look at this piece of content which will help you on your next PR.

Thanks for raising the PR for the issue #44713

Also ,

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.
The list of commits with invalid commit messages:

Update your current PR, with respect to the given message here, choose a commit message which doesn't contain -

  • Issue no. or its description
  • Do not use any hastag

Write clear commit message, so that it can be short and understable, u can look at this article for your next commit messages also look at this piece of content which will help you on your next PR.

Thanks for raising the PR for the issue #44713.

will i have to raise PR again ?

@sftim
Copy link
Contributor

sftim commented Jan 14, 2024

/retitle Revise body of patch request in StatefulSet tutorial

@k8s-ci-robot k8s-ci-robot changed the title fixed #44713 Please enhance the section description at at tutorials/stateful-application/basic-stateful-set/#on-delete Revise body of patch request in StatefulSet tutorial Jan 14, 2024
@sftim
Copy link
Contributor

sftim commented Jan 14, 2024

will i have to raise PR again ?

No. You can edit what you have sent in. However, if you are not sure how to edit an existing commit and would prefer to open a new pull request, you could do that instead.

@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please enhance the section description at tutorials/stateful-application/basic-stateful-set/#on-delete
4 participants