Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document SELinuxMount feature gate #45280

Merged
merged 1 commit into from Mar 15, 2024
Merged

Document SELinuxMount feature gate #45280

merged 1 commit into from Mar 15, 2024

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Feb 22, 2024 •
edited

Add documentation for SELinuxMount feature gate.

KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1710-selinux-relabeling
Issue: kubernetes/enhancements#1710

WIP:

needs the implementation merged first

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language labels Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 22, 2024
@jsafrane jsafrane mentioned this pull request Feb 22, 2024
Open
16 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 22, 2024 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 6a1761c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65f07a2c957c66000819f399

@sftim
Copy link
Contributor

sftim commented Feb 22, 2024

/sig storage security

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/security Categorizes an issue or PR as relevant to SIG Security. labels Feb 22, 2024
@Princesso
Copy link
Contributor

Hello @jsafrane 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

@jsafrane jsafrane changed the title WIP: Document SELinuxMount feature gate Document SELinuxMount feature gate Mar 6, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@jsafrane
Copy link
Member Author

jsafrane commented Mar 6, 2024

I removed WIP:, the PR is ready for review.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2024
@jsafrane @sftim
Document SELinuxMount feature gate
6a1761c 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
@jsafrane
Copy link
Member Author

Thanks for all the suggestions, I squashed them + removed the obsolete note.

sftim
sftim reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1c6a30a5c6980c5fc4844a06e75fc3f687875667

@katcosgrove
Copy link
Contributor

/assign @divya-mohan0209

As the bot has ordained

divya-mohan0209
divya-mohan0209 reviewed Mar 15, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit b8ec2eb into kubernetes:dev-1.30 Mar 15, 2024
6 checks passed
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@sftim sftim sftim left review comments

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

@thockin thockin Awaiting requested review from thockin

Assignees

@divya-mohan0209 divya-mohan0209

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.30
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jsafrane @sftim @Princesso @k8s-ci-robot @katcosgrove @drewhagen @divya-mohan0209