Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2681 PodHostIPs in downward API to stable #45297

Merged
merged 1 commit into from Mar 1, 2024

Conversation

danwinship
Copy link
Contributor

Just updating the text that was added for alpha, #42153. I think this is all that's needed.

/assign @wzshiming

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 22, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 22, 2024
Copy link

netlify bot commented Feb 22, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2a93b5e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/65d7bd6f46c4710008704b54

@dipesh-rawat
Copy link
Member

/sig node network

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Feb 23, 2024
@tengqm
Copy link
Contributor

tengqm commented Feb 24, 2024

/approve

Need to ensure that the upstream code change has been merged before lifting the hold.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2024
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Feb 27, 2024
@danwinship
Copy link
Contributor Author

/hold cancel
(code PR merged)
(still need lgtm here)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@wzshiming
Copy link
Member

/lgtm

Thank you

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ae7286fa7cd2e267081b54b46a7aa0745a8d78c

@k8s-ci-robot k8s-ci-robot merged commit 119f853 into kubernetes:dev-1.30 Mar 1, 2024
6 checks passed
SIG Node PR Triage automation moved this from Triage to Done Mar 1, 2024
@danwinship danwinship deleted the kep-2681-to-ga branch March 1, 2024 13:09
@drewhagen
Copy link
Member

/milestone 1.30

@k8s-ci-robot k8s-ci-robot added this to the 1.30 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

6 participants