Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in RuntimeClassInImageCriApi feature gate #45451

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Fix link in RuntimeClassInImageCriApi feature gate #45451

merged 1 commit into from
Mar 6, 2024

Conversation

dev-johnn
Copy link
Contributor

This will fix #45450

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 6, 2024
@dev-johnn dev-johnn mentioned this pull request Mar 6, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented Mar 6, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 77fb1c2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/65e86bd444c1460008b82e96
😎 Deploy Preview https://deploy-preview-45451--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 08d2570ca9b6deb5186b296508aee7b623c33972

sftim
sftim reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6a76086 into kubernetes:main Mar 6, 2024
6 checks passed
@dev-johnn dev-johnn deleted the fix-isssue45450 branch March 10, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

Assignees

@stmcginnis stmcginnis

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link in the description of RuntimeClassInImageCriApi on "Feature Gates" page
4 participants
@dev-johnn @stmcginnis @k8s-ci-robot @sftim