Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in the description of RuntimeClassInImageCriApi on "Feature Gates" page #45450

Closed
thisisharrsh opened this issue Mar 6, 2024 · 6 comments · Fixed by #45451
Closed

Broken link in the description of RuntimeClassInImageCriApi on "Feature Gates" page #45450

thisisharrsh opened this issue Mar 6, 2024 · 6 comments · Fixed by #45451
Assignees
@dev-johnn
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@thisisharrsh
Copy link
Contributor

This is a Bug Report

Problem: In the List of feature gates section of the Feature gates page, there is a section of RuntimeClassInImageCriApi that has an issue with the hyperlinking of the text. The runtime class is not hyperlinked properly.

Proposed Solution: We should link the runtime class with the appropriate link, i.e., https://kubernetes.io/docs/concepts/containers/runtime-class/

Page to Update: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
@thisisharrsh thisisharrsh added the kind/bug Categorizes issue or PR as related to a bug. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 6, 2024
@thisisharrsh
Copy link
Contributor Author

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 6, 2024
@thisisharrsh
Copy link
Contributor Author

I would to like to work on this issue, if the triage gets accepted.

@dipesh-rawat
Copy link
Member

/retitle Broken link in the description of RuntimeClassInImageCriApi on "Feature Gates" page

@k8s-ci-robot k8s-ci-robot changed the title Inconsistency in the Feature Gates page Broken link in the description of RuntimeClassInImageCriApi on "Feature Gates" page Mar 6, 2024
@dev-johnn dev-johnn mentioned this issue Mar 6, 2024
Merged
@dipesh-rawat
Copy link
Member

Fixes are welcomed.

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 6, 2024
@dev-johnn
Copy link
Contributor

I have raised PR #45451 to fix this problem.

@dev-johnn
Copy link
Contributor

@dipesh-rawat Could you please review and merge the PR whenever free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dev-johnn dev-johnn

Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix link in RuntimeClassInImageCriApi feature gate dev-johnn/website
4 participants
@dipesh-rawat @k8s-ci-robot @thisisharrsh @dev-johnn