Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stale docs about LB annotation #46590

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Fix stale docs about LB annotation #46590

merged 1 commit into from
Jun 1, 2024

Conversation

thisisharrsh
Copy link
Contributor

…ernal-load-balancers

Fixes : #46575

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 30, 2024
@thisisharrsh thisisharrsh mentioned this pull request May 30, 2024
Closed
@netlify Netlify
Copy link

netlify bot commented May 30, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f1c004
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/665801a3b28a4800080ebdcb
😎 Deploy Preview https://deploy-preview-46590--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thisisharrsh
Copy link
Contributor Author

Deployment preview : https://deploy-preview-46590--kubernetes-io-main-staging.netlify.app/docs/reference/labels-annotations-taints/#node-kubernetes-io-exclude-from-external-load-balancers

sftim
sftim reviewed Jun 1, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle Fix stale docs about LB annotation
/lgtm

@k8s-ci-robot k8s-ci-robot changed the title fixed the stale documentation on node.kubernetes.io/exclude-from-ext… Fix stale docs about LB annotation Jun 1, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 28b5e4d60e6c261d3424a9c63e209750ce1e14ba

sftim
sftim reviewed Jun 1, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with a caveat, this is an improvement.

/lgtm
/approve

content/en/docs/reference/labels-annotations-taints/_index.md
Comment on lines 631 to 632
The following command can be used to exclude a worker node from the list of backend servers in a
backend set:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this command always work, or is it only applicable with certain cloud provider integrations? Let's try to document that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should try to test this command with different cloud environment. And later we can update the docs

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4129c1b into kubernetes:main Jun 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@mickeyboxell mickeyboxell Awaiting requested review from mickeyboxell

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node.kubernetes.io/exclude-from-external-load-balancers docs are stale
3 participants
@thisisharrsh @k8s-ci-robot @sftim