Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node.kubernetes.io/exclude-from-external-load-balancers docs are stale #46575

Closed
sftim opened this issue May 29, 2024 · 4 comments · Fixed by #46590
Closed

node.kubernetes.io/exclude-from-external-load-balancers docs are stale #46575

sftim opened this issue May 29, 2024 · 4 comments · Fixed by #46590
Assignees
@thisisharrsh
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented May 29, 2024

This is a Bug Report

Problem:
Well-Known Labels, Annotations and Taints mentions a
ServiceNodeExclusion feature gate; however, Kubernetes v1.23 onwards don't have such a feature gate.
This is in connection with a label, node.kubernetes.io/exclude-from-external-load-balancers.

Proposed Solution:
Drop the mention of the feature gate. Reword the description of that label accordingly.

Page to Update:
https://kubernetes.io/docs/reference/labels-annotations-taints/

Additional Information:
/language en
/kind bug
/priority backlog
@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label May 29, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 29, 2024
@dipesh-rawat
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 29, 2024
@thisisharrsh
Copy link
Contributor

I would to like to work on this issue.
/assign

@thisisharrsh
Copy link
Contributor

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 30, 2024
@thisisharrsh thisisharrsh mentioned this issue May 30, 2024
Merged
@thisisharrsh
Copy link
Contributor

The issue is fixed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thisisharrsh thisisharrsh

Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stale docs about LB annotation thisisharrsh/website
4 participants
@dipesh-rawat @k8s-ci-robot @sftim @thisisharrsh