Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IPv6 information to various Component documents #6535

Closed
wants to merge 150 commits into from

Conversation

mmueen
Copy link
Contributor

@mmueen mmueen commented Dec 1, 2017

What this PR does / why we need it:
Added IPv6 related information to following documents:

docs/concepts/configuration/overview.md
docs/reference/generated/kube-apiserver.md
docs/reference/generated/kube-controller-manager.md
docs/reference/generated/kube-scheduler.md
docs/reference/generated/kubeadm.md
docs/reference/generated/kubelet.md

Which issue(s) this PR addresses:
addresses kubernetes/kubernetes#53824


This change is Reviewable

zacharysarah and others added 30 commits October 19, 2017 16:12
This is kind of jarring / missing an article. I'm guessing it should either be ' to a rack of bare metal servers.' or '...to racks of bare metal servers.'.
 - support request
 - code bug report
Fix the not-working test case yaml for /doc/concepts/storage/volumes.md
Some edits for clarity and condensed language.
Fix format.
The url no need. just  highlight.
Fix leading spaces in commands.
I believe this should be "users" not "uses"
guarnatees  to guarantees
kow3ns and others added 3 commits December 11, 2017 17:28
* updates sts concept and tutorials to use 1.9 apps/v1

* Update statefulset.md

* clarify pod name label
* 1.9 gc policy update

* carify deletion
@steveperry-53 steveperry-53 added this to the 1.9 milestone Dec 12, 2017
@steveperry-53
Copy link
Contributor

We also need to remove kubelet.md from this PR, because it is auto generated. See #6658.

@zacharysarah
Copy link
Contributor

  • Changing base to master post-1.9 release
  • Please resolve the merge conflicts

@zacharysarah zacharysarah changed the base branch from release-1.9 to master December 16, 2017 03:08
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 16, 2017
@zacharysarah zacharysarah removed this from Cleanup in Release 1.9 Dec 16, 2017
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 16, 2017
@mmueen
Copy link
Contributor Author

mmueen commented Dec 16, 2017

@zacharysarah

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 2849cf0

https://deploy-preview-6535--kubernetes-io-master-staging.netlify.com

@steveperry-53
Copy link
Contributor

@mmueen Sorry for the delay. It looks like there's another merge conflict. If you can fix the conflict, I'll get this merged right away. Thanks.

@chenopis chenopis changed the base branch from master to release-1.9 January 9, 2018 02:25
@chenopis chenopis changed the base branch from release-1.9 to master January 9, 2018 02:25
@chenopis
Copy link
Contributor

chenopis commented Jan 9, 2018

This PR needs to be rebased. The commit history is all muddled. Based on the changes mentioned in the description and issue, this PR should not touch anything except for docs/concepts/configuration/overview.md since the rest of the changes should be to the auto-generated docs upstream.

Probably best to just create a clean fork off of master and cherrypick your commits.

@steveperry-53
Copy link
Contributor

steveperry-53 commented Jan 9, 2018

@mmueen If you'd like to collaborate on getting the IPv6 changes into the upstream source for topics like kube-apiserver, you can get in touch with me in the sig-docs Slack channel. I have a PR in progress that discusses how generate reference docs: #6366. Preview of relevant topic.

It looks to me like the upstream source for the kube-apiserver options is in files like serving.go.

@mmueen
Copy link
Contributor Author

mmueen commented Jan 9, 2018

@steveperry-53 , sure yes I can help with that ..
and i agree with @chenopis , i never made those changes to the files which have conflicts now ..

@steveperry-53
Copy link
Contributor

steveperry-53 commented Jan 25, 2018

These changes are covered in the Kubernetes source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet