Blog Migration: Continuation of WIP PR #7144 #7247
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
/assign @chenopis |
tehut
force-pushed
the
master
branch
5 times, most recently
from
bd7054d
to
8a6aa54
Compare
|
👋 I tracked down the netlify failure (either above, or related to https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5a83dc1cfd0efa61de658997) - there's an issue with dependencies when using the jekyll plugins that were defined and added as a part of this work - specifically "jekyll-youtube". I'll circle back and see if I can help identify what versions are needed, as I was doing some emergency repair work on dependency updates recently to solve a build/deploy failure sequence yesterday |
|
/assign |
|
I snagged this and rebased it, resolving the netlify build problem. One gemfile needed to be updated, and the whole Gemfile.lock benefited from an update. You can see the delta comparing to #7416. The short notes on how to do this: and then review the Gemfile and Gemfile.lock files for changes. I can make a PR back to tehut's branch, you can just cherry pick what you want from my branch, or you can replicate the steps - but it's important to rebase this off github.com/kubernetes/website master branch to also get the changes we made to resolve from jekyll build breaks yesterday |
|
It does look like you've enabled maintainers to update this branch, so there's also the option of me pushing a commit onto this branch if that would be easier... |
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 04e9733 https://deploy-preview-7247--kubernetes-io-master-staging.netlify.com |
|
@heckj Thanks again and I'm sorry I didn't see the comments on this PR earlier! I updated the PR with your commit and everything worked beautifully so feel free to close #7416. @zacharysarah , et al I added a small fix to the sidebar and it looks like it fixed one thing and broke another. Just wanted to document that I've seen the issue and will address it in my next PR |
tehut
force-pushed
the
master
branch
10 times, most recently
from
5848e70
to
0432621
Compare
k8s-ci-robot
added
the
cncf-cla: yes
updating Gemfile.lock with bundle install (rvm use ruby-2.2.9) Updated links in header and footer switch to paginate v2 gem comment sidebar logic fixing css regression retry paginate updated local ruby version reverting to original pagination gem remove text, make heading roboto, next/prev as buttons
|
@zacharysarah @heckj Sorry about the delay with my rebase. It looks like everything but tide pool is passing now. |
format checking new posts shrink fab-icons down to 33px
format checking new posts shrink fab-icons down to 33px
tehut
force-pushed
the
master
branch
2 times, most recently
from
d3edfcd
to
47b798b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heckj, zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* WIP * fixing layouts and assets updating Gemfile.lock with bundle install (rvm use ruby-2.2.9) Updated links in header and footer switch to paginate v2 gem comment sidebar logic fixing css regression retry paginate updated local ruby version reverting to original pagination gem remove text, make heading roboto, next/prev as buttons * reintoduce dir tree changes format checking new posts shrink fab-icons down to 33px * reintoduce dir tree changes format checking new posts shrink fab-icons down to 33px * next/prev buttons on posts and index * Change "latest" to v1.10 * rename .md to match old blog and added explict permalinks for urls * replacing a link to old blog
UPDATE (@zacharysarah): Closes #5823
Continuation of WIP PR #7144
Migration currently feature complete with the following issues remaining to be resolved:
Intended Fix: Switch from official paginate gem to popular paginate-v2
- inconsistent resolution of liquid tags by official paginate gem on aggregation page
- had some trouble propagating changes that appeared on the index page. This is part
of the issue with the main paginate-gem and the primary reason to switch
Still missing:
WIP Blog Integration #7144
This change is