-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix responsive around sidebar on blog #8281
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deploy preview for kubernetes-io-master-staging ready! Built with commit 550d355 https://deploy-preview-8281--kubernetes-io-master-staging.netlify.com |
Here is a screenshot of https://deploy-preview-8281--kubernetes-io-master-staging.netlify.com/blog/ on width 320px, which is not perfect (it has 460px): |
77579ba
to
9177a88
Compare
9177a88
to
550d355
Compare
/assign @tehut Sorry if the assign tags are spam, but I figure someone who's worked on the CSS and on the blog migration should take a look. It looks to me as though probably we need other fixes as well, so not sure this PR is the right direction to take. Maybe? If y'all are good with it, an /lgtm will let sig-docs approve and merge. If not, feel free to review or close as you see fit. Or if you don't have permissions, lmk. Thanks! |
@Bradamant3: GitHub didn't allow me to assign the following users: tehut. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @chenopis |
@tnir 👋 We've migrated the site's framework to Hugo. Please re-open this PR with changes to files in their post-migration location ( |
@zacharysarah Thank you for you review. I just updated this with a newer PR. |
Fix responsive layout broken after blog migration (#7247)
For mobile, we would see as below: