Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix responsive around sidebar on blog #8281

Closed
wants to merge 1 commit into from

Conversation

tnir
Copy link
Contributor

@tnir tnir commented May 1, 2018

Fix responsive layout broken after blog migration (#7247)

For mobile, we would see as below:

blog-on-mobile-device

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: chenopis

Assign the PR to them by writing /assign @chenopis in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 1, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 550d355

https://deploy-preview-8281--kubernetes-io-master-staging.netlify.com

@tnir
Copy link
Contributor Author

tnir commented May 2, 2018

Here is a screenshot of https://deploy-preview-8281--kubernetes-io-master-staging.netlify.com/blog/ on width 320px, which is not perfect (it has 460px):

deploy-preview-8281--kubernetes-io-master-staging_netlify_com_blog

@tnir tnir force-pushed the blog-responsive-for-mobile branch from 77579ba to 9177a88 Compare May 2, 2018 13:17
@tnir tnir force-pushed the blog-responsive-for-mobile branch from 9177a88 to 550d355 Compare May 2, 2018 13:26
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2018
@Bradamant3
Copy link
Contributor

/assign @tehut
/assign @alexcontini

Sorry if the assign tags are spam, but I figure someone who's worked on the CSS and on the blog migration should take a look. It looks to me as though probably we need other fixes as well, so not sure this PR is the right direction to take. Maybe? If y'all are good with it, an /lgtm will let sig-docs approve and merge. If not, feel free to review or close as you see fit. Or if you don't have permissions, lmk. Thanks!

@k8s-ci-robot
Copy link
Contributor

@Bradamant3: GitHub didn't allow me to assign the following users: tehut.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @tehut
/assign @alexcontini

Sorry if the assign tags are spam, but I figure someone who's worked on the CSS and on the blog migration should take a look. It looks to me as though probably we need other fixes as well, so not sure this PR is the right direction to take. Maybe? If y'all are good with it, an /lgtm will let sig-docs approve and merge. If not, feel free to review or close as you see fit. Or if you don't have permissions, lmk. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Bradamant3 Bradamant3 requested review from heckj and removed request for zhangxiaoyu-zidif and bradtopol May 2, 2018 15:36
@tnir
Copy link
Contributor Author

tnir commented May 3, 2018

/assign @chenopis

@zacharysarah
Copy link
Contributor

@tnir 👋 We've migrated the site's framework to Hugo. Please re-open this PR with changes to files in their post-migration location (/content/en/blog/...) and reference this PR in the new PR's description.

@tnir
Copy link
Contributor Author

tnir commented May 18, 2018

@zacharysarah Thank you for you review. I just updated this with a newer PR.

@tnir tnir deleted the blog-responsive-for-mobile branch May 18, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants