Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeadm-init.md for broken url #8562

Merged
merged 2 commits into from
May 16, 2018

Conversation

girikuncoro
Copy link
Contributor

@girikuncoro girikuncoro commented May 16, 2018

Fix broken links on kubeadm-init.md that includes reference to kubeadm token, upgrade, reset, and join pages.

Fix broken kubeadm token link
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 16, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit a238b9e

https://deploy-preview-8562--kubernetes-io-master-staging.netlify.com

@neolit123
Copy link
Member

hi, this isn't the only broken link on the page.
could you please update the rest?:
e.g. for join, upgrade, reset.

Broken links are fixed including kubeadm-join, kubeadm-upgrade, and kubeadm-reset
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 16, 2018
@girikuncoro
Copy link
Contributor Author

@neolit123 fixed more broken links on this page, can you review again?

@Bradamant3
Copy link
Contributor

Thanks for fixing! Thanks also to @neolit123 for the review.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bradamant3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit fbfb8c4 into kubernetes:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants