Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate YAML files [part-8] #9347

Merged
merged 4 commits into from
Jul 3, 2018
Merged

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jul 2, 2018

This PR exacts the YAML files referenced from the following subdirs:

  • docs/concepts/workloads
  • docs/concepts/configuration
  • docs/concepts/policy

The following problems are fixed:

  • docs/concepts/workloads/controllers/ doesnt have a 'cronjob.yaml for
    test
  • the exactly same pod.yaml was used in both the task/config-pod-container
    topic and the concepts/configuration topics.

@tengqm tengqm requested a review from steveperry-53 July 2, 2018 05:29
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2018
This PR exacts the YAML files referenced from the following subdirs:

- docs/concepts/workloads
- docs/concepts/configuration
- docs/concepts/policy

The following problems are fixed:

- docs/concepts/workloads/controllers/ doesnt have a 'cronjob.yaml for
  test
- the exactly same `pod.yaml` was used in both the task/config-pod-container
  topic and the concepts/configuration topics.
@steveperry-53
Copy link
Contributor

/hold
Need to fix Netlify preview problem.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 69afff2

https://deploy-preview-9347--kubernetes-io-master-staging.netlify.com

@steveperry-53
Copy link
Contributor

/hold cancel
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveperry-53

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit b5f6df9 into kubernetes:master Jul 3, 2018
@tengqm tengqm deleted the move-yaml-8 branch July 3, 2018 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants