-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links in API reference docs #9795
Conversation
This PR fixes the links generated in the API reference docs.
Deploy preview for kubernetes-io-master-staging ready! Built with commit 56bef56 https://deploy-preview-9795--kubernetes-io-master-staging.netlify.com |
Hi @tengqm, I wonder how the files are generated. Thanks! ref: #9756 (comment) |
@xiangpengzhao refer to: kubernetes-incubator/reference-docs project. The logic fixed is in PR kubernetes-sigs/reference-docs#55 If you want to generate the api references locally, clone the repo, review the first few lines of the Makefile and then do |
@tengqm Thanks! Awesome! |
Assigning @zacharysarah I believe this is all correct but its such a huge change I think @zacharysarah should take a look. |
@tengqm Thanks for this! ✨ /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes the links generated in the API reference docs.
This PR fixes the links generated in the API reference docs.
This PR fixes the links generated in the API reference docs.
This PR fixes the links generated in the API reference docs.
Closes: #9649, #9748