Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore upgrade checker error #1396

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Feb 23, 2024

Description

Changes proposed in this pull request:

  • Ignore upgrade checker error, otherwise engine cannot start until e.g. rate limit is reset:
    [OS]     https://api.github.com/repos/kubeshop/botkube/releases/latest: 403 API rate limit exceeded for 188.147.12.104. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 48m53s]
    

This can be done using HEAD request, that doesn't count against rate limits, I can do it in the follow-up, see example: https://github.com/mszostok/version/blob/a69cf43b345ccd616da915912e2dc9deb8bfc992/upgrade/github/head_fetch.go#L23-L54

@mszostok mszostok added the bug Something isn't working label Feb 23, 2024
@mszostok mszostok requested review from PrasadG193 and a team as code owners February 23, 2024 14:00
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mszostok mszostok merged commit 73c3588 into kubeshop:main Feb 23, 2024
14 of 16 checks passed
@mszostok mszostok deleted the fix-upgrade-err branch February 23, 2024 15:14
mszostok added a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants