feat: support helm repo #3332
Merged
feat: support helm repo #3332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
mortada-codes
commented
May 31, 2023
| @@ -42,7 +42,7 @@ export const Menu = styled.div` | |||
| gap: 20px; | |||
| margin-top: 10px; | |||
|
|
|||
| & div:nth-child(6) { | |||
| & div:last-child { | |||
There was a problem hiding this comment.
check with Catalin
mortada-codes
commented
May 31, 2023
| @@ -40,6 +40,12 @@ const StartPage: React.FC = () => { | |||
| dispatch(toggleStartProjectPane()); | |||
| }; | |||
|
|
|||
| const onClickBrowseHelmCharts = () => { | |||
| dispatch(setIsInQuickClusterMode(true)); | |||
There was a problem hiding this comment.
check with Catalin
olensmar
reviewed
Jun 1, 2023
olensmar
reviewed
Jun 1, 2023
olensmar
reviewed
Jun 1, 2023
olensmar
reviewed
Jun 1, 2023
src/components/organisms/HelmRepoPane/HelmChartDetails/HelmChartDetails.tsx
Outdated
Show resolved
Hide resolved
olensmar
reviewed
Jun 1, 2023
| return loading ? ( | ||
| <Skeleton active={loading} /> | ||
| ) : ( | ||
| <MonacoEditor |
There was a problem hiding this comment.
@devcatalin will this cause any issues/conflicts with the Monaco editor we are using for editing?
olensmar
reviewed
Jun 1, 2023
src/components/organisms/HelmRepoPane/HelmChartDetails/HelmChartTabs/HelmTemplate.tsx
Outdated
Show resolved
Hide resolved
topliceanurazvan
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
Changes
Fixes
How to test it
Screenshots
Checklist